ui/spice-input: Remove superfluous forward declaration

[PATCH] ui/spice-input: Remove superfluous forward declaration

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

We only need to forward-declare kbd_push_key() and kbd_get_leds()
which are used in kbd_interface, not kbd_leds(). Remove this
superfluous forward declaration.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 ui/spice-input.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/spice-input.c b/ui/spice-input.c
index d5bba231c95..21990fa9962 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
 
 static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
 static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
-static void kbd_leds(void *opaque, int l);
 
 static const SpiceKbdInterface kbd_interface = {
     .base.type          = SPICE_INTERFACE_KEYBOARD,
-- 
2.26.2

Re: [PATCH] ui/spice-input: Remove superfluous forward declaration

Posted by Laurent Vivier 3 years, 7 months ago

Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit :
> We only need to forward-declare kbd_push_key() and kbd_get_leds()
> which are used in kbd_interface, not kbd_leds(). Remove this
> superfluous forward declaration.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  ui/spice-input.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index d5bba231c95..21990fa9962 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
>  
>  static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
>  static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
> -static void kbd_leds(void *opaque, int l);
>  
>  static const SpiceKbdInterface kbd_interface = {
>      .base.type          = SPICE_INTERFACE_KEYBOARD,
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH] ui/spice-input: Remove superfluous forward declaration

Posted by Laurent Vivier 3 years, 7 months ago

Le 09/09/2020 à 19:11, Philippe Mathieu-Daudé a écrit :
> We only need to forward-declare kbd_push_key() and kbd_get_leds()
> which are used in kbd_interface, not kbd_leds(). Remove this
> superfluous forward declaration.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  ui/spice-input.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index d5bba231c95..21990fa9962 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -36,7 +36,6 @@ typedef struct QemuSpiceKbd {
>  
>  static void kbd_push_key(SpiceKbdInstance *sin, uint8_t frag);
>  static uint8_t kbd_get_leds(SpiceKbdInstance *sin);
> -static void kbd_leds(void *opaque, int l);
>  
>  static const SpiceKbdInterface kbd_interface = {
>      .base.type          = SPICE_INTERFACE_KEYBOARD,
> 

Applied to my trivial-patches branch.

Thanks,
Laurent