hw/s390x/css: Remove double initialization

[PATCH] hw/s390x/css: Remove double initialization

Philippe Mathieu-Daudé posted 1 patch 3 years, 7 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200907024020.854465-1-philmd@redhat.com

Maintainers: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>

hw/s390x/css.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] hw/s390x/css: Remove double initialization

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

Fix eventual copy/paste mistake introduced in commit bc994b74ea
("s390x/css: Use static initialization for channel_subsys fields").

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/s390x/css.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 519dc91316d..9961cfe7bf6 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
     .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
     .do_crw_mchk = true,
     .sei_pending = false,
-    .do_crw_mchk = true,
     .crws_lost = false,
     .chnmon_active = false,
     .indicator_addresses =
-- 
2.26.2

Re: [PATCH] hw/s390x/css: Remove double initialization

Posted by Thomas Huth 3 years, 7 months ago

On 07/09/2020 04.40, Philippe Mathieu-Daudé wrote:
> Fix eventual copy/paste mistake introduced in commit bc994b74ea
> ("s390x/css: Use static initialization for channel_subsys fields").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/s390x/css.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 519dc91316d..9961cfe7bf6 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
>      .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
>      .do_crw_mchk = true,
>      .sei_pending = false,
> -    .do_crw_mchk = true,
>      .crws_lost = false,
>      .chnmon_active = false,
>      .indicator_addresses =
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] hw/s390x/css: Remove double initialization

Posted by Cornelia Huck 3 years, 7 months ago

On Mon,  7 Sep 2020 04:40:20 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Fix eventual copy/paste mistake introduced in commit bc994b74ea
> ("s390x/css: Use static initialization for channel_subsys fields").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/s390x/css.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 519dc91316d..9961cfe7bf6 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -353,7 +353,6 @@ static ChannelSubSys channel_subsys = {
>      .pending_crws = QTAILQ_HEAD_INITIALIZER(channel_subsys.pending_crws),
>      .do_crw_mchk = true,
>      .sei_pending = false,
> -    .do_crw_mchk = true,
>      .crws_lost = false,
>      .chnmon_active = false,
>      .indicator_addresses =

Thanks, applied.