1. Patchew
  2. QEMU
  3. View series

[PATCH] tests: fixes test-vmstate.c compile error on msys2

Yonggang Luo posted 1 patch 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200905063813.1875-1-luoyonggang@gmail.com
tests/test-vmstate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by Yonggang Luo 3 years, 7 months ago 
../tests/test-vmstate.c: In function 'int_cmp':
../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
  884 |     uint ua = GPOINTER_TO_UINT(a);
      |     ^~~~
      |     uInt
../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
  885 |     uint ub = GPOINTER_TO_UINT(b);
      |     ^~~~
      |     uInt
make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 tests/test-vmstate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index f7b3868881..f8de709a0b 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
 /* ID comparison function */
 static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
 {
-    uint ua = GPOINTER_TO_UINT(a);
-    uint ub = GPOINTER_TO_UINT(b);
+    guint ua = GPOINTER_TO_UINT(a);
+    guint ub = GPOINTER_TO_UINT(b);
     return (ua > ub) - (ua < ub);
 }
 
-- 
2.28.0.windows.1
Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by Thomas Huth 3 years, 7 months ago 
On 05/09/2020 08.38, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by 罗勇刚 (Yonggang Luo) 3 years, 7 months ago 
On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com> wrote:

> On 05/09/2020 08.38, Yonggang Luo wrote:
> > ../tests/test-vmstate.c: In function 'int_cmp':
> > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   884 |     uint ua = GPOINTER_TO_UINT(a);
> >       |     ^~~~
> >       |     uInt
> > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> >   885 |     uint ub = GPOINTER_TO_UINT(b);
> >       |     ^~~~
> >       |     uInt
> > make: ***
> [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >  tests/test-vmstate.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> > index f7b3868881..f8de709a0b 100644
> > --- a/tests/test-vmstate.c
> > +++ b/tests/test-vmstate.c
> > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> >  /* ID comparison function */
> >  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
> user_data)
> >  {
> > -    uint ua = GPOINTER_TO_UINT(a);
> > -    uint ub = GPOINTER_TO_UINT(b);
> > +    guint ua = GPOINTER_TO_UINT(a);
> > +    guint ub = GPOINTER_TO_UINT(b);
> >      return (ua > ub) - (ua < ub);
> >  }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Does this means quened or to be queued, if that's true, will skip this
next revision


-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by Thomas Huth 3 years, 7 months ago 
On 05/09/2020 18.16, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
> 
>     On 05/09/2020 08.38, Yonggang Luo wrote:
>     > ../tests/test-vmstate.c: In function 'int_cmp':
>     > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint';
>     did you mean 'uInt'?
>     >   884 |     uint ua = GPOINTER_TO_UINT(a);
>     >       |     ^~~~
>     >       |     uInt
>     > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint';
>     did you mean 'uInt'?
>     >   885 |     uint ub = GPOINTER_TO_UINT(b);
>     >       |     ^~~~
>     >       |     uInt
>     > make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-
>     vmstate.c.obj] 错误 1
>     >
>     > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
>     <mailto:luoyonggang@gmail.com>>
>     > ---
>     >  tests/test-vmstate.c | 4 ++--
>     >  1 file changed, 2 insertions(+), 2 deletions(-)
>     >
>     > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
>     > index f7b3868881..f8de709a0b 100644
>     > --- a/tests/test-vmstate.c
>     > +++ b/tests/test-vmstate.c
>     > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
>     gconstpointer b, gpointer user_data)
>     >  /* ID comparison function */
>     >  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
>     user_data)
>     >  {
>     > -    uint ua = GPOINTER_TO_UINT(a);
>     > -    uint ub = GPOINTER_TO_UINT(b);
>     > +    guint ua = GPOINTER_TO_UINT(a);
>     > +    guint ub = GPOINTER_TO_UINT(b);
>     >      return (ua > ub) - (ua < ub);
>     >  }
> 
>     Reviewed-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
> 
> Does this means quened or to be queued, if that's true, will skip this
> next revision 

No, "Reviewed-by" just means that somebody looked at the patch and
thinks it is right. It does not mean that it is queued yet, but it
certainly helps that the patch gets accepted.
But I've also put the qemu-trivial mailing list on CC: - trivial paches
like this can often get picked up more easily via the trivial queue.
Otherwise this should maybe get merged via the migration tree, or Alex'
or my testing tree.

 Thomas
Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by Philippe Mathieu-Daudé 3 years, 7 months ago 
On 9/5/20 8:38 AM, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }
>  
>
Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
Posted by 罗勇刚 (Yonggang Luo) 3 years, 7 months ago 
Bonzini, you need have a look at this

On Sat, Sep 5, 2020 at 2:38 PM Yonggang Luo <luoyonggang@gmail.com> wrote:

> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
>   884 |     uint ua = GPOINTER_TO_UINT(a);
>       |     ^~~~
>       |     uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
>   885 |     uint ub = GPOINTER_TO_UINT(b);
>       |     ^~~~
>       |     uInt
> make: ***
> [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/test-vmstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
>  /* ID comparison function */
>  static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
>  {
> -    uint ua = GPOINTER_TO_UINT(a);
> -    uint ub = GPOINTER_TO_UINT(b);
> +    guint ua = GPOINTER_TO_UINT(a);
> +    guint ub = GPOINTER_TO_UINT(b);
>      return (ua > ub) - (ua < ub);
>  }
>
> --
> 2.28.0.windows.1
>
>

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.