[PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines

Cleber Rosa posted 7 patches 5 years, 5 months ago
[PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines
Posted by Cleber Rosa 5 years, 5 months ago
When waiting for a pipeline to run and finish, it's better to give
early feedback, and then sleep and wait, than the other wait around.

Specially for the first iteration, it's frustrating to see nothing
while the script is sleeping.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 scripts/ci/gitlab-pipeline-status | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
index 2a36f74696..18609553be 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval,
 
         status = get_pipeline_status(project_id, commit_sha)
         if status['status'] == 'running':
-            time.sleep(interval)
             print('running...')
+            time.sleep(interval)
             continue
 
         if status['status'] == 'success':
-- 
2.25.4


Re: [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines
Posted by Philippe Mathieu-Daudé 5 years, 5 months ago
On 9/4/20 6:42 PM, Cleber Rosa wrote:
> When waiting for a pipeline to run and finish, it's better to give
> early feedback, and then sleep and wait, than the other wait around.
> 
> Specially for the first iteration, it's frustrating to see nothing
> while the script is sleeping.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  scripts/ci/gitlab-pipeline-status | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
> index 2a36f74696..18609553be 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval,
>  
>          status = get_pipeline_status(project_id, commit_sha)
>          if status['status'] == 'running':
> -            time.sleep(interval)
>              print('running...')
> +            time.sleep(interval)
>              continue
>  
>          if status['status'] == 'success':
>