tests/qtest: do not list ahci-test twice

[PATCH] tests/qtest: do not list ahci-test twice

Paolo Bonzini posted 1 patch 3 years, 7 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200904120342.11370-1-pbonzini@redhat.com

Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/meson.build | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] tests/qtest: do not list ahci-test twice

Posted by Paolo Bonzini 3 years, 7 months ago

This is caught by "meson test", which complains about two tests with the
same name.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/qtest/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 8f8fdb1336..874b5be62b 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -49,7 +49,6 @@ qtests_i386 = \
   qtests_pci +                                                                              \
   ['fdc-test',
    'ide-test',
-   'ahci-test',
    'hd-geo-test',
    'boot-order-test',
    'bios-tables-test',
-- 
2.26.2

Re: [PATCH] tests/qtest: do not list ahci-test twice

Posted by Thomas Huth 3 years, 7 months ago

On 04/09/2020 14.03, Paolo Bonzini wrote:
> This is caught by "meson test", which complains about two tests with the
> same name.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qtest/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 8f8fdb1336..874b5be62b 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -49,7 +49,6 @@ qtests_i386 = \
>    qtests_pci +                                                                              \
>    ['fdc-test',
>     'ide-test',
> -   'ahci-test',
>     'hd-geo-test',
>     'boot-order-test',
>     'bios-tables-test',
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

... and since you just sent your meson PR without this, I can also take
it through my qtest-next tree.

Re: [PATCH] tests/qtest: do not list ahci-test twice

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

On 9/4/20 2:03 PM, Paolo Bonzini wrote:
> This is caught by "meson test", which complains about two tests with the
> same name.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qtest/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 8f8fdb1336..874b5be62b 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -49,7 +49,6 @@ qtests_i386 = \
>    qtests_pci +                                                                              \
>    ['fdc-test',
>     'ide-test',
> -   'ahci-test',
>     'hd-geo-test',
>     'boot-order-test',
>     'bios-tables-test',
> 

Fixes: a2ce7dbd917 ("meson: convert tests/qtest to meson")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>