This code was never compiled/used, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/timer/hpet.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 380acfa7c8a..b683f64f1d3 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -416,20 +416,6 @@ static void hpet_del_timer(HPETTimer *t)
update_irq(t, 0);
}
-#ifdef HPET_DEBUG
-static uint32_t hpet_ram_readb(void *opaque, hwaddr addr)
-{
- printf("qemu: hpet_read b at %" PRIx64 "\n", addr);
- return 0;
-}
-
-static uint32_t hpet_ram_readw(void *opaque, hwaddr addr)
-{
- printf("qemu: hpet_read w at %" PRIx64 "\n", addr);
- return 0;
-}
-#endif
-
static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
unsigned size)
{
--
2.26.2
On 03/09/2020 15.45, Philippe Mathieu-Daudé wrote:
> This code was never compiled/used, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/hpet.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> index 380acfa7c8a..b683f64f1d3 100644
> --- a/hw/timer/hpet.c
> +++ b/hw/timer/hpet.c
> @@ -416,20 +416,6 @@ static void hpet_del_timer(HPETTimer *t)
> update_irq(t, 0);
> }
>
> -#ifdef HPET_DEBUG
> -static uint32_t hpet_ram_readb(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read b at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -
> -static uint32_t hpet_ram_readw(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read w at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -#endif
> -
> static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
> unsigned size)
> {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Le 03/09/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
> This code was never compiled/used, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/hpet.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> index 380acfa7c8a..b683f64f1d3 100644
> --- a/hw/timer/hpet.c
> +++ b/hw/timer/hpet.c
> @@ -416,20 +416,6 @@ static void hpet_del_timer(HPETTimer *t)
> update_irq(t, 0);
> }
>
> -#ifdef HPET_DEBUG
> -static uint32_t hpet_ram_readb(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read b at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -
> -static uint32_t hpet_ram_readw(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read w at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -#endif
> -
> static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
> unsigned size)
> {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
© 2016 - 2025 Red Hat, Inc.