[PATCH v1 0/8] some testing and CI updates (re-greening)

Alex Bennée posted 8 patches 5 years, 2 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200903112107.27367-1-alex.bennee@linaro.org
Maintainers: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aurelien Jarno <aurelien@aurel32.net>
CODING_STYLE.rst                         | 31 +++++++++++++++--
configure                                |  2 ++
hw/usb/host-libusb.c                     |  2 +-
migration/global_state.c                 |  4 +--
target/mips/translate.c                  | 12 ++-----
.travis.yml                              |  2 +-
crypto/meson.build                       | 42 +++++++++++++++++-------
meson.build                              |  7 ++--
tests/Makefile.include                   | 15 +++++++--
tests/docker/dockerfiles/debian10.docker |  1 +
tests/docker/dockerfiles/debian9.docker  |  1 +
tests/meson.build                        |  3 +-
tests/qemu-iotests/meson.build           |  4 ---
13 files changed, 89 insertions(+), 37 deletions(-)
[PATCH v1 0/8] some testing and CI updates (re-greening)
Posted by Alex Bennée 5 years, 2 months ago
Hi,

My first series after a holiday is a bunch of clean-ups for testing.
Currently they all apply on top of Thomas' pull-request-2020-09-02 tag
which is currently in flight. The fixes to shippable won't become
apparent until the main registry has been updates with the new images
but I have tested them locally.

The migration and mips fixes where just quick band-aids so I would
appreciate the appropriate maintainers having a closer look.

With these we get back to a mostly green state although there seem to
be some acceptance tests that need updating.

Alex Bennée (5):
  CODING_STYLE.rst: flesh out our naming conventions.
  tests/docker: add python3-setuptools the docker images
  tests/meson.build: fp tests don't need CONFIG_TCG
  target/mips: simplify gen_compute_imm_branch logic
  migration: use pstrcpy to copy run state

Daniel P. Berrangé (1):
  crypto: fix build with gcrypt enabled

Gerd Hoffmann (1):
  usb-host: restrict workaround to new libusb versions

Paolo Bonzini (1):
  qemu-iotests: move check-block back to Makefiles

 CODING_STYLE.rst                         | 31 +++++++++++++++--
 configure                                |  2 ++
 hw/usb/host-libusb.c                     |  2 +-
 migration/global_state.c                 |  4 +--
 target/mips/translate.c                  | 12 ++-----
 .travis.yml                              |  2 +-
 crypto/meson.build                       | 42 +++++++++++++++++-------
 meson.build                              |  7 ++--
 tests/Makefile.include                   | 15 +++++++--
 tests/docker/dockerfiles/debian10.docker |  1 +
 tests/docker/dockerfiles/debian9.docker  |  1 +
 tests/meson.build                        |  3 +-
 tests/qemu-iotests/meson.build           |  4 ---
 13 files changed, 89 insertions(+), 37 deletions(-)

-- 
2.20.1


Re: [PATCH v1 0/8] some testing and CI updates (re-greening)
Posted by Daniel P. Berrangé 5 years, 2 months ago
On Thu, Sep 03, 2020 at 12:20:59PM +0100, Alex Bennée wrote:
> Hi,
> 
> My first series after a holiday is a bunch of clean-ups for testing.
> Currently they all apply on top of Thomas' pull-request-2020-09-02 tag
> which is currently in flight. The fixes to shippable won't become
> apparent until the main registry has been updates with the new images
> but I have tested them locally.
> 
> The migration and mips fixes where just quick band-aids so I would
> appreciate the appropriate maintainers having a closer look.
> 
> With these we get back to a mostly green state although there seem to
> be some acceptance tests that need updating.
> 
> Alex Bennée (5):
>   CODING_STYLE.rst: flesh out our naming conventions.
>   tests/docker: add python3-setuptools the docker images
>   tests/meson.build: fp tests don't need CONFIG_TCG
>   target/mips: simplify gen_compute_imm_branch logic
>   migration: use pstrcpy to copy run state
> 
> Daniel P. Berrangé (1):
>   crypto: fix build with gcrypt enabled

Any reason you only picked 1 of the two pathces in that series.
The second patch adds CI to validate that the first patch is
actually correct

https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00279.html

> 
> Gerd Hoffmann (1):
>   usb-host: restrict workaround to new libusb versions
> 
> Paolo Bonzini (1):
>   qemu-iotests: move check-block back to Makefiles
> 
>  CODING_STYLE.rst                         | 31 +++++++++++++++--
>  configure                                |  2 ++
>  hw/usb/host-libusb.c                     |  2 +-
>  migration/global_state.c                 |  4 +--
>  target/mips/translate.c                  | 12 ++-----
>  .travis.yml                              |  2 +-
>  crypto/meson.build                       | 42 +++++++++++++++++-------
>  meson.build                              |  7 ++--
>  tests/Makefile.include                   | 15 +++++++--
>  tests/docker/dockerfiles/debian10.docker |  1 +
>  tests/docker/dockerfiles/debian9.docker  |  1 +
>  tests/meson.build                        |  3 +-
>  tests/qemu-iotests/meson.build           |  4 ---
>  13 files changed, 89 insertions(+), 37 deletions(-)
> 
> -- 
> 2.20.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH v1 0/8] some testing and CI updates (re-greening)
Posted by Thomas Huth 5 years, 2 months ago
On 03/09/2020 13.34, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 12:20:59PM +0100, Alex Bennée wrote:
>> Hi,
>>
>> My first series after a holiday is a bunch of clean-ups for testing.
>> Currently they all apply on top of Thomas' pull-request-2020-09-02 tag
>> which is currently in flight. The fixes to shippable won't become
>> apparent until the main registry has been updates with the new images
>> but I have tested them locally.
>>
>> The migration and mips fixes where just quick band-aids so I would
>> appreciate the appropriate maintainers having a closer look.
>>
>> With these we get back to a mostly green state although there seem to
>> be some acceptance tests that need updating.
>>
>> Alex Bennée (5):
>>   CODING_STYLE.rst: flesh out our naming conventions.
>>   tests/docker: add python3-setuptools the docker images
>>   tests/meson.build: fp tests don't need CONFIG_TCG
>>   target/mips: simplify gen_compute_imm_branch logic
>>   migration: use pstrcpy to copy run state
>>
>> Daniel P. Berrangé (1):
>>   crypto: fix build with gcrypt enabled
> 
> Any reason you only picked 1 of the two pathces in that series.
> The second patch adds CI to validate that the first patch is
> actually correct
 I guess Alex dropped it because there is a (simple) conflict with one
of my patches ("gitlab/travis: Rework the disabled features tests") ...
should be easy to fix, though.

I'm also preparing yet another patch series for improving the gitlab-CI
(with the cross-compiler patches), so I can also put your crypto gitlab
patch in there if you like.

 Thomas


Re: [PATCH v1 0/8] some testing and CI updates (re-greening)
Posted by Alex Bennée 5 years, 2 months ago
Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Sep 03, 2020 at 12:20:59PM +0100, Alex Bennée wrote:
>> Hi,
>> 
>> My first series after a holiday is a bunch of clean-ups for testing.
>> Currently they all apply on top of Thomas' pull-request-2020-09-02 tag
>> which is currently in flight. The fixes to shippable won't become
>> apparent until the main registry has been updates with the new images
>> but I have tested them locally.
>> 
>> The migration and mips fixes where just quick band-aids so I would
>> appreciate the appropriate maintainers having a closer look.
>> 
>> With these we get back to a mostly green state although there seem to
>> be some acceptance tests that need updating.
>> 
>> Alex Bennée (5):
>>   CODING_STYLE.rst: flesh out our naming conventions.
>>   tests/docker: add python3-setuptools the docker images
>>   tests/meson.build: fp tests don't need CONFIG_TCG
>>   target/mips: simplify gen_compute_imm_branch logic
>>   migration: use pstrcpy to copy run state
>> 
>> Daniel P. Berrangé (1):
>>   crypto: fix build with gcrypt enabled
>
> Any reason you only picked 1 of the two pathces in that series.
> The second patch adds CI to validate that the first patch is
> actually correct
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00279.html

Oops, i got dropped when I re-based on Thomas' tree and I erroneously
thought it was because it conflicted with itself rather than another
change. I'll include it in v2.

>
>> 
>> Gerd Hoffmann (1):
>>   usb-host: restrict workaround to new libusb versions
>> 
>> Paolo Bonzini (1):
>>   qemu-iotests: move check-block back to Makefiles
>> 
>>  CODING_STYLE.rst                         | 31 +++++++++++++++--
>>  configure                                |  2 ++
>>  hw/usb/host-libusb.c                     |  2 +-
>>  migration/global_state.c                 |  4 +--
>>  target/mips/translate.c                  | 12 ++-----
>>  .travis.yml                              |  2 +-
>>  crypto/meson.build                       | 42 +++++++++++++++++-------
>>  meson.build                              |  7 ++--
>>  tests/Makefile.include                   | 15 +++++++--
>>  tests/docker/dockerfiles/debian10.docker |  1 +
>>  tests/docker/dockerfiles/debian9.docker  |  1 +
>>  tests/meson.build                        |  3 +-
>>  tests/qemu-iotests/meson.build           |  4 ---
>>  13 files changed, 89 insertions(+), 37 deletions(-)
>> 
>> -- 
>> 2.20.1
>> 
>
> Regards,
> Daniel


-- 
Alex Bennée