[v3] Green the msys2 CI make

[PATCH v3 00/12] Green the msys2 CI make

Yonggang Luo posted 12 patches 5 years, 1 month ago

Diff against v1 v2 v4 v5
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200903074313.1498-1-luoyonggang@gmail.com

Maintainers: Markus Armbruster <armbru@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Wen Congyang <wencongyang2@huawei.com>, Kevin Wolf <kwolf@redhat.com>, Li-Wen Hsu <lwhsu@freebsd.org>, Xie Changlong <xiechanglong.d@gmail.com>, Ed Maste <emaste@freebsd.org>, Max Reitz <mreitz@redhat.com>, Peter Lieven <pl@kamp.de>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Cleber Rosa <crosa@redhat.com>, Richard Henderson <rth@twiddle.net>

There is a newer version of this series

.cirrus.yml                         |   108 +-
block/nfs.c                         |  1812 +--
capstone                            |     2 +-
configure                           | 16560 +++++++++++++-------------
include/qemu/osdep.h                |  1372 +--
include/tcg/tcg.h                   |  2898 ++---
meson.build                         |  2994 ++---
scripts/ci/windows/msys2_build.sh   |    33 +
scripts/ci/windows/msys2_install.sh |    31 +
scripts/undefsym.py                 |    57 +
scripts/undefsym.sh                 |    20 -
stubs/notify-event.c                |     8 +-
tcg/tcg-op-gvec.c                   |  7012 +++++------
tests/Makefile.include              |  1086 +-
tests/qapi-schema/meson.build       |   451 +-
tests/test-replication.c            |  1214 +-
16 files changed, 17904 insertions(+), 17754 deletions(-)
create mode 100644 scripts/ci/windows/msys2_build.sh
create mode 100644 scripts/ci/windows/msys2_install.sh
create mode 100644 scripts/undefsym.py
delete mode 100755 scripts/undefsym.sh

Expand all Fold all

[PATCH v3 00/12] Green the msys2 CI make

Posted by Yonggang Luo 5 years, 1 month ago

Also it's fixes issues about make check

Yonggang Luo (12):
  configure: fixes dtc not cloned when running msys2 CI
  meson: Convert undefsym.sh to undefsym.py
  tcg: Fixes dup_const link error
  tests: handling signal on win32 properly
  configure: Fix include and linkage issue on msys2
  block: Fixes nfs on msys2/mingw
  osdep: These function are only available on Non-Win32 system.
  ci: fixes msys2 build by upgrading capstone to 4.0.2
  stubs: qemu_notify_event have no need to stub
  meson: Fixes qapi tests.
  tests: Disable test-image-locking that not works under Win32
  ci: Enable msys2 ci in cirrus

 .cirrus.yml                         |   108 +-
 block/nfs.c                         |  1812 +--
 capstone                            |     2 +-
 configure                           | 16560 +++++++++++++-------------
 include/qemu/osdep.h                |  1372 +--
 include/tcg/tcg.h                   |  2898 ++---
 meson.build                         |  2994 ++---
 scripts/ci/windows/msys2_build.sh   |    33 +
 scripts/ci/windows/msys2_install.sh |    31 +
 scripts/undefsym.py                 |    57 +
 scripts/undefsym.sh                 |    20 -
 stubs/notify-event.c                |     8 +-
 tcg/tcg-op-gvec.c                   |  7012 +++++------
 tests/Makefile.include              |  1086 +-
 tests/qapi-schema/meson.build       |   451 +-
 tests/test-replication.c            |  1214 +-
 16 files changed, 17904 insertions(+), 17754 deletions(-)
 create mode 100644 scripts/ci/windows/msys2_build.sh
 create mode 100644 scripts/ci/windows/msys2_install.sh
 create mode 100644 scripts/undefsym.py
 delete mode 100755 scripts/undefsym.sh

-- 
2.28.0.windows.1

Re: [PATCH v3 00/12] Green the msys2 CI make

Posted by Paolo Bonzini 5 years, 1 month ago

Please send patches more slowly. You already have several queued, and
resending them only adds confusion.

Paolo

Il gio 3 set 2020, 09:43 Yonggang Luo <luoyonggang@gmail.com> ha scritto:

> Also it's fixes issues about make check
>
> Yonggang Luo (12):
>   configure: fixes dtc not cloned when running msys2 CI
>   meson: Convert undefsym.sh to undefsym.py
>   tcg: Fixes dup_const link error
>   tests: handling signal on win32 properly
>   configure: Fix include and linkage issue on msys2
>   block: Fixes nfs on msys2/mingw
>   osdep: These function are only available on Non-Win32 system.
>   ci: fixes msys2 build by upgrading capstone to 4.0.2
>   stubs: qemu_notify_event have no need to stub
>   meson: Fixes qapi tests.
>   tests: Disable test-image-locking that not works under Win32
>   ci: Enable msys2 ci in cirrus
>
>  .cirrus.yml                         |   108 +-
>  block/nfs.c                         |  1812 +--
>  capstone                            |     2 +-
>  configure                           | 16560 +++++++++++++-------------
>  include/qemu/osdep.h                |  1372 +--
>  include/tcg/tcg.h                   |  2898 ++---
>  meson.build                         |  2994 ++---
>  scripts/ci/windows/msys2_build.sh   |    33 +
>  scripts/ci/windows/msys2_install.sh |    31 +
>  scripts/undefsym.py                 |    57 +
>  scripts/undefsym.sh                 |    20 -
>  stubs/notify-event.c                |     8 +-
>  tcg/tcg-op-gvec.c                   |  7012 +++++------
>  tests/Makefile.include              |  1086 +-
>  tests/qapi-schema/meson.build       |   451 +-
>  tests/test-replication.c            |  1214 +-
>  16 files changed, 17904 insertions(+), 17754 deletions(-)
>  create mode 100644 scripts/ci/windows/msys2_build.sh
>  create mode 100644 scripts/ci/windows/msys2_install.sh
>  create mode 100644 scripts/undefsym.py
>  delete mode 100755 scripts/undefsym.sh
>
> --
> 2.28.0.windows.1
>
>
>

Re: [PATCH v3 00/12] Green the msys2 CI make

Posted by 罗勇刚 (Yonggang Luo) 5 years, 1 month ago

On Thu, Sep 3, 2020 at 3:58 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Please send patches more slowly. You already have several queued, and
> resending them only adds confusion.
>
> OK, sorry for that.

> Paolo
>
> Il gio 3 set 2020, 09:43 Yonggang Luo <luoyonggang@gmail.com> ha scritto:
>
>> Also it's fixes issues about make check
>>
>> Yonggang Luo (12):
>>   configure: fixes dtc not cloned when running msys2 CI
>>   meson: Convert undefsym.sh to undefsym.py
>>   tcg: Fixes dup_const link error
>>   tests: handling signal on win32 properly
>>   configure: Fix include and linkage issue on msys2
>>   block: Fixes nfs on msys2/mingw
>>   osdep: These function are only available on Non-Win32 system.
>>   ci: fixes msys2 build by upgrading capstone to 4.0.2
>>   stubs: qemu_notify_event have no need to stub
>>   meson: Fixes qapi tests.
>>   tests: Disable test-image-locking that not works under Win32
>>   ci: Enable msys2 ci in cirrus
>>
>>  .cirrus.yml                         |   108 +-
>>  block/nfs.c                         |  1812 +--
>>  capstone                            |     2 +-
>>  configure                           | 16560 +++++++++++++-------------
>>  include/qemu/osdep.h                |  1372 +--
>>  include/tcg/tcg.h                   |  2898 ++---
>>  meson.build                         |  2994 ++---
>>  scripts/ci/windows/msys2_build.sh   |    33 +
>>  scripts/ci/windows/msys2_install.sh |    31 +
>>  scripts/undefsym.py                 |    57 +
>>  scripts/undefsym.sh                 |    20 -
>>  stubs/notify-event.c                |     8 +-
>>  tcg/tcg-op-gvec.c                   |  7012 +++++------
>>  tests/Makefile.include              |  1086 +-
>>  tests/qapi-schema/meson.build       |   451 +-
>>  tests/test-replication.c            |  1214 +-
>>  16 files changed, 17904 insertions(+), 17754 deletions(-)
>>  create mode 100644 scripts/ci/windows/msys2_build.sh
>>  create mode 100644 scripts/ci/windows/msys2_install.sh
>>  create mode 100644 scripts/undefsym.py
>>  delete mode 100755 scripts/undefsym.sh
>>
>> --
>> 2.28.0.windows.1
>>
>>
>>

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

Re: [PATCH v3 00/12] Green the msys2 CI make

Posted by Daniel P. Berrangé 5 years, 1 month ago

On Thu, Sep 03, 2020 at 03:43:01PM +0800, Yonggang Luo wrote:
> Also it's fixes issues about make check
> 
> Yonggang Luo (12):
>   configure: fixes dtc not cloned when running msys2 CI
>   meson: Convert undefsym.sh to undefsym.py
>   tcg: Fixes dup_const link error
>   tests: handling signal on win32 properly
>   configure: Fix include and linkage issue on msys2
>   block: Fixes nfs on msys2/mingw
>   osdep: These function are only available on Non-Win32 system.
>   ci: fixes msys2 build by upgrading capstone to 4.0.2
>   stubs: qemu_notify_event have no need to stub
>   meson: Fixes qapi tests.
>   tests: Disable test-image-locking that not works under Win32
>   ci: Enable msys2 ci in cirrus
> 
>  .cirrus.yml                         |   108 +-
>  block/nfs.c                         |  1812 +--
>  capstone                            |     2 +-
>  configure                           | 16560 +++++++++++++-------------
>  include/qemu/osdep.h                |  1372 +--
>  include/tcg/tcg.h                   |  2898 ++---
>  meson.build                         |  2994 ++---
>  scripts/ci/windows/msys2_build.sh   |    33 +
>  scripts/ci/windows/msys2_install.sh |    31 +
>  scripts/undefsym.py                 |    57 +
>  scripts/undefsym.sh                 |    20 -
>  stubs/notify-event.c                |     8 +-
>  tcg/tcg-op-gvec.c                   |  7012 +++++------
>  tests/Makefile.include              |  1086 +-
>  tests/qapi-schema/meson.build       |   451 +-
>  tests/test-replication.c            |  1214 +-
>  16 files changed, 17904 insertions(+), 17754 deletions(-)

This whole series is messed up adding/removing 1000's of lines of
code with no change. I'm assuming you've introduced DOS line
endings causing a massive diff


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|