[v2] Fix oss-fuzz builds post-meson integration

[PATCH v2 0/3] Fix oss-fuzz builds post-meson integration

Alexander Bulekov posted 3 patches 5 years, 2 months ago

Diff against v1 v1
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200902173652.307222-1-alxndr@bu.edu

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Laurent Vivier <lvivier@redhat.com>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

configure                    | 12 ++++++++++--
meson.build                  |  9 ++++++++-
scripts/oss-fuzz/build.sh    |  2 +-
tests/qtest/fuzz/meson.build |  7 ++-----
4 files changed, 21 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Fix oss-fuzz builds post-meson integration

Posted by Alexander Bulekov 5 years, 2 months ago

Since v1:
 * FUZZ_LINK_COMMAND -> FUZZ_EXE_LDFLAGS
 * Add a separate call to add_project_link_arguments, rather than
   appending to config_host['QEMU_LDFLAGS']
 * Remove stray comment in tests/qtest/fuzz/meson.build

QEMU stopped building on oss-fuzz, after the meson integration, due to
some linking issues:

https://oss-fuzz-build-logs.storage.googleapis.com/log-3eaddfbd-7e05-4ddd-9d86-ee4b16c0fac6.txt

Those problems should be partially fixed by:

Depends-on: meson: fix libqos linking
(https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00802.html)

These patches:
1. Build on the above patch to fix the way we specify the linker script,
   to ensure that it is not specified within start-group/end-group linker
   pairs
2. Add support for running --enable-fuzzing with a custom LIB_FUZZING_ENGINE
3. Fix a problem with how we specify custom rpath in the oss-fuzz
   build-script

Alexander Bulekov (3):
  meson: specify fuzz linker script as a project arg
  fuzz: Add support for custom fuzzing library
  scripts/oss-fuzz/build.sh: fix rpath

 configure                    | 12 ++++++++++--
 meson.build                  |  9 ++++++++-
 scripts/oss-fuzz/build.sh    |  2 +-
 tests/qtest/fuzz/meson.build |  7 ++-----
 4 files changed, 21 insertions(+), 9 deletions(-)

-- 
2.28.0

Re: [PATCH v2 0/3] Fix oss-fuzz builds post-meson integration

Posted by Paolo Bonzini 5 years, 2 months ago

On 02/09/20 19:36, Alexander Bulekov wrote:
> Since v1:
>  * FUZZ_LINK_COMMAND -> FUZZ_EXE_LDFLAGS
>  * Add a separate call to add_project_link_arguments, rather than
>    appending to config_host['QEMU_LDFLAGS']
>  * Remove stray comment in tests/qtest/fuzz/meson.build
> 
> QEMU stopped building on oss-fuzz, after the meson integration, due to
> some linking issues:
> 
> https://oss-fuzz-build-logs.storage.googleapis.com/log-3eaddfbd-7e05-4ddd-9d86-ee4b16c0fac6.txt
> 
> Those problems should be partially fixed by:
> 
> Depends-on: meson: fix libqos linking
> (https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00802.html)
> 
> These patches:
> 1. Build on the above patch to fix the way we specify the linker script,
>    to ensure that it is not specified within start-group/end-group linker
>    pairs
> 2. Add support for running --enable-fuzzing with a custom LIB_FUZZING_ENGINE
> 3. Fix a problem with how we specify custom rpath in the oss-fuzz
>    build-script
> 
> Alexander Bulekov (3):
>   meson: specify fuzz linker script as a project arg
>   fuzz: Add support for custom fuzzing library
>   scripts/oss-fuzz/build.sh: fix rpath
> 
>  configure                    | 12 ++++++++++--
>  meson.build                  |  9 ++++++++-
>  scripts/oss-fuzz/build.sh    |  2 +-
>  tests/qtest/fuzz/meson.build |  7 ++-----
>  4 files changed, 21 insertions(+), 9 deletions(-)
> 

Queued, thanks.

Paolo