hw/gpio: Replace printf() calls by qemu_log_mask()

[PATCH 2/2] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP)

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

Replace disabled printf() by qemu_log_mask(UNIMP).

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/gpio/max7310.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c
index 7f5de189acf..c58a1996418 100644
--- a/hw/gpio/max7310.c
+++ b/hw/gpio/max7310.c
@@ -11,6 +11,7 @@
 #include "hw/i2c/i2c.h"
 #include "hw/irq.h"
 #include "migration/vmstate.h"
+#include "qemu/log.h"
 #include "qemu/module.h"
 
 #define TYPE_MAX7310 "max7310"
@@ -69,9 +70,8 @@ static uint8_t max7310_rx(I2CSlave *i2c)
         return 0xff;
 
     default:
-#ifdef VERBOSE
-        printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+                      __func__, s->command);
         break;
     }
     return 0xff;
@@ -123,9 +123,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data)
     case 0x00:	/* Input port - ignore writes */
         break;
     default:
-#ifdef VERBOSE
-        printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+                      __func__, s->command);
         return 1;
     }
 
-- 
2.26.2

Re: [PATCH 2/2] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP)

Posted by Laurent Vivier 5 years, 5 months ago

Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit :
> Replace disabled printf() by qemu_log_mask(UNIMP).
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/gpio/max7310.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c
> index 7f5de189acf..c58a1996418 100644
> --- a/hw/gpio/max7310.c
> +++ b/hw/gpio/max7310.c
> @@ -11,6 +11,7 @@
>  #include "hw/i2c/i2c.h"
>  #include "hw/irq.h"
>  #include "migration/vmstate.h"
> +#include "qemu/log.h"
>  #include "qemu/module.h"
>  
>  #define TYPE_MAX7310 "max7310"
> @@ -69,9 +70,8 @@ static uint8_t max7310_rx(I2CSlave *i2c)
>          return 0xff;
>  
>      default:
> -#ifdef VERBOSE
> -        printf("%s: unknown register %02x\n", __func__, s->command);
> -#endif
> +        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
> +                      __func__, s->command);
>          break;
>      }
>      return 0xff;
> @@ -123,9 +123,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data)
>      case 0x00:	/* Input port - ignore writes */
>          break;
>      default:
> -#ifdef VERBOSE
> -        printf("%s: unknown register %02x\n", __func__, s->command);
> -#endif
> +        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
> +                      __func__, s->command);
>          return 1;
>      }
>  
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH 2/2] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP)

Posted by Laurent Vivier 5 years, 5 months ago

Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit :
> Replace disabled printf() by qemu_log_mask(UNIMP).
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/gpio/max7310.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c
> index 7f5de189acf..c58a1996418 100644
> --- a/hw/gpio/max7310.c
> +++ b/hw/gpio/max7310.c
> @@ -11,6 +11,7 @@
>  #include "hw/i2c/i2c.h"
>  #include "hw/irq.h"
>  #include "migration/vmstate.h"
> +#include "qemu/log.h"
>  #include "qemu/module.h"
>  
>  #define TYPE_MAX7310 "max7310"
> @@ -69,9 +70,8 @@ static uint8_t max7310_rx(I2CSlave *i2c)
>          return 0xff;
>  
>      default:
> -#ifdef VERBOSE
> -        printf("%s: unknown register %02x\n", __func__, s->command);
> -#endif
> +        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
> +                      __func__, s->command);
>          break;
>      }
>      return 0xff;
> @@ -123,9 +123,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data)
>      case 0x00:	/* Input port - ignore writes */
>          break;
>      default:
> -#ifdef VERBOSE
> -        printf("%s: unknown register %02x\n", __func__, s->command);
> -#endif
> +        qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
> +                      __func__, s->command);
>          return 1;
>      }
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent