hw/acpi/tco: Remove unused definitions

[PATCH] hw/acpi/tco: Remove unused definitions

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

TCO_DEBUG() and DEBUG definitions are not used, remove them.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/acpi/tco.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
index fb9052dbca2..cf1e68a5393 100644
--- a/hw/acpi/tco.c
+++ b/hw/acpi/tco.c
@@ -15,17 +15,6 @@
 #include "hw/acpi/tco.h"
 #include "trace.h"
 
-//#define DEBUG
-
-#ifdef DEBUG
-#define TCO_DEBUG(fmt, ...)                                     \
-    do {                                                        \
-        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
-    } while (0)
-#else
-#define TCO_DEBUG(fmt, ...) do { } while (0)
-#endif
-
 enum {
     TCO_RLD_DEFAULT         = 0x0000,
     TCO_DAT_IN_DEFAULT      = 0x00,
-- 
2.26.2

Re: [PATCH] hw/acpi/tco: Remove unused definitions

Posted by Laurent Vivier 3 years, 8 months ago

Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :
> TCO_DEBUG() and DEBUG definitions are not used, remove them.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/acpi/tco.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index fb9052dbca2..cf1e68a5393 100644
> --- a/hw/acpi/tco.c
> +++ b/hw/acpi/tco.c
> @@ -15,17 +15,6 @@
>  #include "hw/acpi/tco.h"
>  #include "trace.h"
>  
> -//#define DEBUG
> -
> -#ifdef DEBUG
> -#define TCO_DEBUG(fmt, ...)                                     \
> -    do {                                                        \
> -        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
> -    } while (0)
> -#else
> -#define TCO_DEBUG(fmt, ...) do { } while (0)
> -#endif
> -
>  enum {
>      TCO_RLD_DEFAULT         = 0x0000,
>      TCO_DAT_IN_DEFAULT      = 0x00,
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH] hw/acpi/tco: Remove unused definitions

Posted by Laurent Vivier 3 years, 7 months ago

Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :
> TCO_DEBUG() and DEBUG definitions are not used, remove them.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/acpi/tco.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index fb9052dbca2..cf1e68a5393 100644
> --- a/hw/acpi/tco.c
> +++ b/hw/acpi/tco.c
> @@ -15,17 +15,6 @@
>  #include "hw/acpi/tco.h"
>  #include "trace.h"
>  
> -//#define DEBUG
> -
> -#ifdef DEBUG
> -#define TCO_DEBUG(fmt, ...)                                     \
> -    do {                                                        \
> -        fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__);    \
> -    } while (0)
> -#else
> -#define TCO_DEBUG(fmt, ...) do { } while (0)
> -#endif
> -
>  enum {
>      TCO_RLD_DEFAULT         = 0x0000,
>      TCO_DAT_IN_DEFAULT      = 0x00,
> 

Applied to my trivial-patches branch.

Thanks,
Laurent