[PULL 24/24] meson: add description to options

Paolo Bonzini posted 24 patches 5 years, 5 months ago
Maintainers: Kevin Wolf <kwolf@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Max Reitz <mreitz@redhat.com>, Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Cornelia Huck <cohuck@redhat.com>
There is a newer version of this series
[PULL 24/24] meson: add description to options
Posted by Paolo Bonzini 5 years, 5 months ago
This will be useful in the future to generate configure
command line parsing from meson_options.txt.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson_options.txt | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/meson_options.txt b/meson_options.txt
index c3120fa359..3e772f55b3 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -2,12 +2,23 @@ option('qemu_suffix', type : 'string', value: 'qemu',
        description: 'Suffix for QEMU data/modules/config directories (can be empty)')
 option('docdir', type : 'string', value : 'doc',
        description: 'Base directory for documentation installation (can be empty)')
-option('gettext', type : 'boolean', value : true)
-option('sdl', type : 'feature', value : 'auto')
-option('sdl_image', type : 'feature', value : 'auto')
-option('u2f', type : 'feature', value : 'auto')
-option('vnc', type : 'feature', value : 'enabled')
-option('vnc_jpeg', type : 'feature', value : 'auto')
-option('vnc_png', type : 'feature', value : 'auto')
-option('vnc_sasl', type : 'feature', value : 'auto')
-option('xkbcommon', type : 'feature', value : 'auto')
+
+option('gettext', type : 'boolean', value : true,
+       description: 'Localizationo of the GTK+ user interface')
+
+option('sdl', type : 'feature', value : 'auto',
+       description: 'SDL user interface')
+option('sdl_image', type : 'feature', value : 'auto',
+       description: 'SDL Image support for icons')
+option('u2f', type : 'feature', value : 'auto',
+       description: 'U2F emulation support')
+option('vnc', type : 'feature', value : 'enabled',
+       description: 'VNC server')
+option('vnc_jpeg', type : 'feature', value : 'auto',
+       description: 'JPEG lossy compression for VNC server')
+option('vnc_png', type : 'feature', value : 'auto',
+       description: 'PNG compression for VNC server')
+option('vnc_sasl', type : 'feature', value : 'auto',
+       description: 'SASL authentication for VNC server')
+option('xkbcommon', type : 'feature', value : 'auto',
+       description: 'xkbcommon support')
-- 
2.26.2


Re: [PULL 24/24] meson: add description to options
Posted by Marc-André Lureau 5 years, 5 months ago
Hi

On Tue, Sep 1, 2020 at 1:25 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> This will be useful in the future to generate configure
> command line parsing from meson_options.txt.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson_options.txt | 29 ++++++++++++++++++++---------
>  1 file changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/meson_options.txt b/meson_options.txt
> index c3120fa359..3e772f55b3 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -2,12 +2,23 @@ option('qemu_suffix', type : 'string', value: 'qemu',
>         description: 'Suffix for QEMU data/modules/config directories (can
> be empty)')
>  option('docdir', type : 'string', value : 'doc',
>         description: 'Base directory for documentation installation (can
> be empty)')
> -option('gettext', type : 'boolean', value : true)
> -option('sdl', type : 'feature', value : 'auto')
> -option('sdl_image', type : 'feature', value : 'auto')
> -option('u2f', type : 'feature', value : 'auto')
> -option('vnc', type : 'feature', value : 'enabled')
> -option('vnc_jpeg', type : 'feature', value : 'auto')
> -option('vnc_png', type : 'feature', value : 'auto')
> -option('vnc_sasl', type : 'feature', value : 'auto')
> -option('xkbcommon', type : 'feature', value : 'auto')
> +
> +option('gettext', type : 'boolean', value : true,
> +       description: 'Localizationo of the GTK+ user interface')
>

Hardly a blocker: "Localization"

Also, we may want to remove the extra space before ':' for consistency.

+
> +option('sdl', type : 'feature', value : 'auto',
> +       description: 'SDL user interface')
> +option('sdl_image', type : 'feature', value : 'auto',
> +       description: 'SDL Image support for icons')
> +option('u2f', type : 'feature', value : 'auto',
> +       description: 'U2F emulation support')
> +option('vnc', type : 'feature', value : 'enabled',
> +       description: 'VNC server')
> +option('vnc_jpeg', type : 'feature', value : 'auto',
> +       description: 'JPEG lossy compression for VNC server')
> +option('vnc_png', type : 'feature', value : 'auto',
> +       description: 'PNG compression for VNC server')
> +option('vnc_sasl', type : 'feature', value : 'auto',
> +       description: 'SASL authentication for VNC server')
> +option('xkbcommon', type : 'feature', value : 'auto',
> +       description: 'xkbcommon support')
> --
> 2.26.2
>
>
>

-- 
Marc-André Lureau