meson: add pixman dependency to chardev/baum module

[PATCH] meson: add pixman dependency to chardev/baum module

Stefan Weil posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200830204640.482214-1-sw@weilnetz.de

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>

chardev/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] meson: add pixman dependency to chardev/baum module

Posted by Stefan Weil 3 years, 8 months ago

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---


Together with Paolo's patch (https://patchwork.kernel.org/patch/11745207/)
this fixed the build with --enable-modules for me.

Stefan


 chardev/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/meson.build b/chardev/meson.build
index 7726837e34..27a9a28f4c 100644
--- a/chardev/meson.build
+++ b/chardev/meson.build
@@ -38,7 +38,7 @@ chardev_modules = {}
 
 if config_host.has_key('CONFIG_BRLAPI') and sdl.found()
   module_ss = ss.source_set()
-  module_ss.add(when: [sdl, brlapi], if_true: files('baum.c'))
+  module_ss.add(when: [sdl, brlapi], if_true: [files('baum.c'), pixman])
   chardev_modules += { 'baum': module_ss }
 endif
 
-- 
2.28.0

Re: [PATCH] meson: add pixman dependency to chardev/baum module

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

Le dim. 30 août 2020 22:47, Stefan Weil <sw@weilnetz.de> a écrit :

> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

---
>
>
> Together with Paolo's patch (https://patchwork.kernel.org/patch/11745207/)
> this fixed the build with --enable-modules for me.
>
> Stefan
>
>
>  chardev/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/meson.build b/chardev/meson.build
> index 7726837e34..27a9a28f4c 100644
> --- a/chardev/meson.build
> +++ b/chardev/meson.build
> @@ -38,7 +38,7 @@ chardev_modules = {}
>
>  if config_host.has_key('CONFIG_BRLAPI') and sdl.found()
>    module_ss = ss.source_set()
> -  module_ss.add(when: [sdl, brlapi], if_true: files('baum.c'))
> +  module_ss.add(when: [sdl, brlapi], if_true: [files('baum.c'), pixman])
>    chardev_modules += { 'baum': module_ss }
>  endif
>
> --
> 2.28.0
>
>
>