linux-user: fix ppc/termbits.h

[PATCH] linux-user: fix ppc/termbits.h

Laurent Vivier posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200830181620.422036-1-laurent@vivier.eu

Maintainers: Laurent Vivier <laurent@vivier.eu>

linux-user/ppc/termbits.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] linux-user: fix ppc/termbits.h

Posted by Laurent Vivier 3 years, 8 months ago

On ppc, in termios, c_line is after c_cc, not before .

Fixes: c218b4ede4f9 ("linux-user: Add missing termbits types and values definitions")
Cc: Filip.Bozuta@syrmia.com
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/ppc/termbits.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/ppc/termbits.h b/linux-user/ppc/termbits.h
index 7066d1e5523d..eb226e099980 100644
--- a/linux-user/ppc/termbits.h
+++ b/linux-user/ppc/termbits.h
@@ -14,8 +14,8 @@ struct target_termios {
     target_tcflag_t c_oflag;               /* output mode flags */
     target_tcflag_t c_cflag;               /* control mode flags */
     target_tcflag_t c_lflag;               /* local mode flags */
-    target_cc_t c_line;                    /* line discipline */
     target_cc_t c_cc[TARGET_NCCS];         /* control characters */
+    target_cc_t c_line;                    /* line discipline */
     target_speed_t c_ispeed;               /* input speed */
     target_speed_t c_ospeed;               /* output speed */
 };
-- 
2.26.2

Re: [PATCH] linux-user: fix ppc/termbits.h

Posted by Laurent Vivier 3 years, 8 months ago

Le 30/08/2020 à 20:16, Laurent Vivier a écrit :
> On ppc, in termios, c_line is after c_cc, not before .
> 
> Fixes: c218b4ede4f9 ("linux-user: Add missing termbits types and values definitions")
> Cc: Filip.Bozuta@syrmia.com
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  linux-user/ppc/termbits.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/ppc/termbits.h b/linux-user/ppc/termbits.h
> index 7066d1e5523d..eb226e099980 100644
> --- a/linux-user/ppc/termbits.h
> +++ b/linux-user/ppc/termbits.h
> @@ -14,8 +14,8 @@ struct target_termios {
>      target_tcflag_t c_oflag;               /* output mode flags */
>      target_tcflag_t c_cflag;               /* control mode flags */
>      target_tcflag_t c_lflag;               /* local mode flags */
> -    target_cc_t c_line;                    /* line discipline */
>      target_cc_t c_cc[TARGET_NCCS];         /* control characters */
> +    target_cc_t c_line;                    /* line discipline */
>      target_speed_t c_ispeed;               /* input speed */
>      target_speed_t c_ospeed;               /* output speed */
>  };
> 


Applied to my linux-user-for-5.2 branch.

Thanks,
Laurent