Getting qemu building under msys2 properly

[PATCH 0/2] Getting qemu building under msys2 properly

Yonggang Luo posted 2 patches 3 years, 8 months ago

Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200828162246.423-1-luoyonggang@gmail.com

Maintainers: Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

configure           | 28 +++++++++++++++-------
meson.build         |  2 +-
scripts/undefsym.py | 57 +++++++++++++++++++++++++++++++++++++++++++++
scripts/undefsym.sh | 20 ----------------
4 files changed, 77 insertions(+), 30 deletions(-)
create mode 100644 scripts/undefsym.py
delete mode 100755 scripts/undefsym.sh

Expand all Fold all

[PATCH 0/2] Getting qemu building under msys2 properly

Posted by Yonggang Luo 3 years, 8 months ago

Convert undefsym.sh to undefsym.py and replace $PWD with $build_dir

Yonggang Luo (2):
  meson: Convert undefsym.sh to undefsym.py
  configure: Fix include and linkage issue on msys2

 configure           | 28 +++++++++++++++-------
 meson.build         |  2 +-
 scripts/undefsym.py | 57 +++++++++++++++++++++++++++++++++++++++++++++
 scripts/undefsym.sh | 20 ----------------
 4 files changed, 77 insertions(+), 30 deletions(-)
 create mode 100644 scripts/undefsym.py
 delete mode 100755 scripts/undefsym.sh

-- 
2.27.0.windows.1

Re: [PATCH 0/2] Getting qemu building under msys2 properly

Posted by Paolo Bonzini 3 years, 8 months ago

On 28/08/20 18:22, Yonggang Luo wrote:
> Convert undefsym.sh to undefsym.py and replace $PWD with $build_dir
> 
> Yonggang Luo (2):
>   meson: Convert undefsym.sh to undefsym.py
>   configure: Fix include and linkage issue on msys2
> 
>  configure           | 28 +++++++++++++++-------
>  meson.build         |  2 +-
>  scripts/undefsym.py | 57 +++++++++++++++++++++++++++++++++++++++++++++
>  scripts/undefsym.sh | 20 ----------------
>  4 files changed, 77 insertions(+), 30 deletions(-)
>  create mode 100644 scripts/undefsym.py
>  delete mode 100755 scripts/undefsym.sh
> 

Thanks Yonggang, I'll queue the first patch.

I'll keep an eye on your patch but I prefer to first have the rest of
the build (tests and possibly pc-bios) moved to meson.build.  This way
most of the references to source and build paths from Make (where spaces
are problematic) should go away and it's easier to understand the effect
of the patch.

Paolo