tracetool: show trace-events filename/lineno in fmt string errors

[PATCH 0/4] tracetool: show trace-events filename/lineno in fmt string errors

Stefan Hajnoczi posted 4 patches 5 years, 2 months ago

Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Failed in applying to current master (apply log)

docs/devel/tracing.txt              |  3 +-
meson.build                         |  3 +-
scripts/tracetool.py                | 12 ++++---
scripts/tracetool/__init__.py       | 53 +++++++++++++++++++++++++----
scripts/tracetool/backend/ftrace.py |  4 +++
scripts/tracetool/backend/log.py    |  4 +++
scripts/tracetool/backend/syslog.py |  4 +++
trace/meson.build                   | 23 +++++--------
8 files changed, 76 insertions(+), 30 deletions(-)

Expand all Fold all

[PATCH 0/4] tracetool: show trace-events filename/lineno in fmt string errors

Posted by Stefan Hajnoczi 5 years, 2 months ago

This patch series improves format string compiler error messages. Instead of
showing the generated file, show the trace-events file where the format string
is defined.

Stefan Hajnoczi (4):
  tracetool: add output filename command-line argument
  tracetool: add out_lineno and out_next_lineno to out()
  tracetool: add input filename and line number to Event
  tracetool: show trace-events filename/lineno in fmt string errors

 docs/devel/tracing.txt              |  3 +-
 meson.build                         |  3 +-
 scripts/tracetool.py                | 12 ++++---
 scripts/tracetool/__init__.py       | 53 +++++++++++++++++++++++++----
 scripts/tracetool/backend/ftrace.py |  4 +++
 scripts/tracetool/backend/log.py    |  4 +++
 scripts/tracetool/backend/syslog.py |  4 +++
 trace/meson.build                   | 23 +++++--------
 8 files changed, 76 insertions(+), 30 deletions(-)

-- 
2.26.2

Re: [PATCH 0/4] tracetool: show trace-events filename/lineno in fmt string errors

Posted by Stefan Hajnoczi 4 years, 11 months ago

On Thu, Aug 27, 2020 at 03:29:11PM +0100, Stefan Hajnoczi wrote:
> This patch series improves format string compiler error messages. Instead of
> showing the generated file, show the trace-events file where the format string
> is defined.
> 
> Stefan Hajnoczi (4):
>   tracetool: add output filename command-line argument
>   tracetool: add out_lineno and out_next_lineno to out()
>   tracetool: add input filename and line number to Event
>   tracetool: show trace-events filename/lineno in fmt string errors
> 
>  docs/devel/tracing.txt              |  3 +-
>  meson.build                         |  3 +-
>  scripts/tracetool.py                | 12 ++++---
>  scripts/tracetool/__init__.py       | 53 +++++++++++++++++++++++++----
>  scripts/tracetool/backend/ftrace.py |  4 +++
>  scripts/tracetool/backend/log.py    |  4 +++
>  scripts/tracetool/backend/syslog.py |  4 +++
>  trace/meson.build                   | 23 +++++--------
>  8 files changed, 76 insertions(+), 30 deletions(-)
> 
> -- 
> 2.26.2
> 

Thanks, applied to my tracing-next tree:
https://gitlab.com/stefanha/qemu/commits/tracing-next

Stefan