Deprecate lm32 port

[PATCH] Deprecate lm32 port

Posted by Peter Maydell 3 years, 8 months ago

Deprecate our lm32 target support. Michael Walle (former lm32 maintainer)
suggested that we do this in 2019:
 https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
because the only public user of the architecture is the many-years-dead
milkymist project. (The Linux port to lm32 was never merged upstream.)

In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
the MAINTAINERS file, but didn't officially deprecate it. Mark it
deprecated now, with the intention of removing it from QEMU in
mid-2021 before the 6.1 release.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Based-on: 20200825172719.19422-1-peter.maydell@linaro.org
("Deprecate Unicore32 port") to avoid the obvious textual-conflict.

 docs/system/deprecated.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 4c52098c707..5c7fc8a3c99 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -416,6 +416,14 @@ The above, converted to the current supported format::
 linux-user mode CPUs
 --------------------
 
+``lm32`` CPUs (since 5.2.0)
+'''''''''''''''''''''''''''
+
+The ``lm32`` guest CPU support is deprecated and will be removed in
+a future version of QEMU. The only public user of this architecture
+was the milkymist project, which has been dead for years; there was
+never an upstream Linux port.
+
 ``unicore32`` CPUs (since 5.2.0)
 ''''''''''''''''''''''''''''''''
 
-- 
2.20.1

Re: [PATCH] Deprecate lm32 port

Posted by Daniel P. Berrangé 3 years, 8 months ago

On Thu, Aug 27, 2020 at 12:32:59PM +0100, Peter Maydell wrote:
> Deprecate our lm32 target support. Michael Walle (former lm32 maintainer)
> suggested that we do this in 2019:
>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
> because the only public user of the architecture is the many-years-dead
> milkymist project. (The Linux port to lm32 was never merged upstream.)
> 
> In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
> the MAINTAINERS file, but didn't officially deprecate it. Mark it
> deprecated now, with the intention of removing it from QEMU in
> mid-2021 before the 6.1 release.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Based-on: 20200825172719.19422-1-peter.maydell@linaro.org
> ("Deprecate Unicore32 port") to avoid the obvious textual-conflict.
> 
>  docs/system/deprecated.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] Deprecate lm32 port

Posted by Michael Walle 3 years, 8 months ago

Am 27. August 2020 13:32:59 MESZ schrieb Peter Maydell <peter.maydell@linaro.org>:
>Deprecate our lm32 target support. Michael Walle (former lm32
>maintainer)
>suggested that we do this in 2019:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
>because the only public user of the architecture is the many-years-dead
>milkymist project. (The Linux port to lm32 was never merged upstream.)
>
>In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
>the MAINTAINERS file, but didn't officially deprecate it. Mark it
>deprecated now, with the intention of removing it from QEMU in
>mid-2021 before the 6.1 release.
>
>Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Acked-by: Michael Walle <michael@walle.cc>

Thanks, 
-michael

Re: [PATCH] Deprecate lm32 port

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

Le jeu. 27 août 2020 14:07, Michael Walle <michael@walle.cc> a écrit :

> Am 27. August 2020 13:32:59 MESZ schrieb Peter Maydell <
> peter.maydell@linaro.org>:
> >Deprecate our lm32 target support. Michael Walle (former lm32
> >maintainer)
> >suggested that we do this in 2019:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
> >because the only public user of the architecture is the many-years-dead
> >milkymist project. (The Linux port to lm32 was never merged upstream.)
> >
> >In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
> >the MAINTAINERS file, but didn't officially deprecate it. Mark it
> >deprecated now, with the intention of removing it from QEMU in
> >mid-2021 before the 6.1 release.
> >
> >Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Acked-by: Michael Walle <michael@walle.cc>
>

Thanks Michael for your contributions. I could learn few things looking at
the code and the git history.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> Thanks,
> -michael
>
>
>

Re: [PATCH] Deprecate lm32 port

Posted by Thomas Huth 3 years, 8 months ago

On 27/08/2020 13.32, Peter Maydell wrote:
> Deprecate our lm32 target support. Michael Walle (former lm32 maintainer)
> suggested that we do this in 2019:
>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
> because the only public user of the architecture is the many-years-dead
> milkymist project. (The Linux port to lm32 was never merged upstream.)
> 
> In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
> the MAINTAINERS file, but didn't officially deprecate it. Mark it
> deprecated now, with the intention of removing it from QEMU in
> mid-2021 before the 6.1 release.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Based-on: 20200825172719.19422-1-peter.maydell@linaro.org
> ("Deprecate Unicore32 port") to avoid the obvious textual-conflict.
> 
>  docs/system/deprecated.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 4c52098c707..5c7fc8a3c99 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -416,6 +416,14 @@ The above, converted to the current supported format::
>  linux-user mode CPUs
>  --------------------
>  
> +``lm32`` CPUs (since 5.2.0)
> +'''''''''''''''''''''''''''
> +
> +The ``lm32`` guest CPU support is deprecated and will be removed in
> +a future version of QEMU. The only public user of this architecture
> +was the milkymist project, which has been dead for years; there was
> +never an upstream Linux port.

Reviewed-by: Thomas Huth <thuth@redhat.com>

What's next? moxie? ... apart from the tree-wide clean-ups and trivial
fixes, moxie did not have any major updates since 2013 when it has been
added, as far as I can see ... is anybody still using it?

Re: [PATCH] Deprecate lm32 port

Posted by Peter Maydell 3 years, 8 months ago

On Thu, 27 Aug 2020 at 14:52, Thomas Huth <thuth@redhat.com> wrote:
> What's next? moxie? ... apart from the tree-wide clean-ups and trivial
> fixes, moxie did not have any major updates since 2013 when it has been
> added, as far as I can see ... is anybody still using it?

I was never very clear on how much use moxie had to start with...

An extremely rough-and-ready guide to how well-loved a target
is might be "did it get converted to TranslatorOps?". Unconverted:
 * avr
 * cris
 * lm32 (deprecation in progress)
 * microblaze (rth just posted patches for this)
 * moxie
 * nios2
 * tilegx (deprecation in progress)
 * unicore32 (deprecation in progress)

As I say, very rough-and-ready: we have had recent interest in nios2;
avr has just got into the tree so hopefully the maintainer will have
a look at TranslatorOps conversion; Edgar is still around for cris.

I think dropping the moxie maintainer an email to ask about the
architecture's status wouldn't be a bad idea if you wanted to start
that ball rolling.

thanks
-- PMM

Re: [PATCH] Deprecate lm32 port

Posted by Thomas Huth 3 years, 8 months ago

On 27/08/2020 16.19, Peter Maydell wrote:
> On Thu, 27 Aug 2020 at 14:52, Thomas Huth <thuth@redhat.com> wrote:
>> What's next? moxie? ... apart from the tree-wide clean-ups and trivial
>> fixes, moxie did not have any major updates since 2013 when it has been
>> added, as far as I can see ... is anybody still using it?
> 
> I was never very clear on how much use moxie had to start with...
> 
> An extremely rough-and-ready guide to how well-loved a target
> is might be "did it get converted to TranslatorOps?". Unconverted:
>  * avr
>  * cris
>  * lm32 (deprecation in progress)
>  * microblaze (rth just posted patches for this)
>  * moxie
>  * nios2
>  * tilegx (deprecation in progress)
>  * unicore32 (deprecation in progress)

Another criteria might be: Do we have a tcg, qtest or acceptance test to
check that the target is still working?

- avr has an acceptance test

- cris has tcg tests

- lm32 has tcg tests

- microblaze has acceptance tests (and one trivial qtest)

- moxie ... has only one very trivial qtest (boot-serial-test)

- nios2 has an acceptance test

- tilegx does not have any tests at all

- unicore32 does not have any tests at all
  (not counting the trivial machine-none-test)

So from that point of view, unicore32, tilegx and moxie are the
candidates for deprecation.

> I think dropping the moxie maintainer an email to ask about
> the architecture's status wouldn't be a bad idea if you
> wanted to start that ball rolling.

Ok, good idea, I'll try to write a mail later today.

 Thomas

Re: [PATCH] Deprecate lm32 port

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

Le jeu. 27 août 2020 16:51, Thomas Huth <thuth@redhat.com> a écrit :

> On 27/08/2020 16.19, Peter Maydell wrote:
> > On Thu, 27 Aug 2020 at 14:52, Thomas Huth <thuth@redhat.com> wrote:
> >> What's next? moxie? ... apart from the tree-wide clean-ups and trivial
> >> fixes, moxie did not have any major updates since 2013 when it has been
> >> added, as far as I can see ... is anybody still using it?
> >
> > I was never very clear on how much use moxie had to start with...
> >
> > An extremely rough-and-ready guide to how well-loved a target
> > is might be "did it get converted to TranslatorOps?". Unconverted:
> >  * avr
> >  * cris
> >  * lm32 (deprecation in progress)
> >  * microblaze (rth just posted patches for this)
> >  * moxie
> >  * nios2
> >  * tilegx (deprecation in progress)
> >  * unicore32 (deprecation in progress)
>
> Another criteria might be: Do we have a tcg, qtest or acceptance test to
> check that the target is still working?
>

And to some extent "is there documentation publicly available?" as it makes
maintenance by others possible.


> - avr has an acceptance test
>
> - cris has tcg tests
>
> - lm32 has tcg tests
>
> - microblaze has acceptance tests (and one trivial qtest)
>
> - moxie ... has only one very trivial qtest (boot-serial-test)
>
> - nios2 has an acceptance test
>
> - tilegx does not have any tests at all
>
> - unicore32 does not have any tests at all
>   (not counting the trivial machine-none-test)
>
> So from that point of view, unicore32, tilegx and moxie are the
> candidates for deprecation.
>
> > I think dropping the moxie maintainer an email to ask about
> > the architecture's status wouldn't be a bad idea if you
> > wanted to start that ball rolling.
>
> Ok, good idea, I'll try to write a mail later today.
>
>  Thomas
>
>
>

Re: [PATCH] Deprecate lm32 port

Posted by Thomas Huth 3 years, 7 months ago

On 27/08/2020 13.32, Peter Maydell wrote:
> Deprecate our lm32 target support. Michael Walle (former lm32 maintainer)
> suggested that we do this in 2019:
>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html
> because the only public user of the architecture is the many-years-dead
> milkymist project. (The Linux port to lm32 was never merged upstream.)
> 
> In commit 4b4d96c776f552e (March 2020) we marked it as 'orphan' in
> the MAINTAINERS file, but didn't officially deprecate it. Mark it
> deprecated now, with the intention of removing it from QEMU in
> mid-2021 before the 6.1 release.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Based-on: 20200825172719.19422-1-peter.maydell@linaro.org
> ("Deprecate Unicore32 port") to avoid the obvious textual-conflict.
> 
>  docs/system/deprecated.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 4c52098c707..5c7fc8a3c99 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -416,6 +416,14 @@ The above, converted to the current supported format::
>  linux-user mode CPUs
>  --------------------
>  
> +``lm32`` CPUs (since 5.2.0)
> +'''''''''''''''''''''''''''
> +
> +The ``lm32`` guest CPU support is deprecated and will be removed in
> +a future version of QEMU. The only public user of this architecture
> +was the milkymist project, which has been dead for years; there was
> +never an upstream Linux port.

I was just looking at the current version of deprecated.rst (which has
this patch included), and could it be that it ended up in the wrong
section here? "lm32" is rather a softmmu target, not a linux-user mode CPU?

 Thomas

Re: [PATCH] Deprecate lm32 port

Posted by Peter Maydell 3 years, 7 months ago

On Wed, 23 Sep 2020 at 08:55, Thomas Huth <thuth@redhat.com> wrote:
>
> On 27/08/2020 13.32, Peter Maydell wrote:
> > @@ -416,6 +416,14 @@ The above, converted to the current supported format::
> >  linux-user mode CPUs
> >  --------------------
> >
> > +``lm32`` CPUs (since 5.2.0)
> > +'''''''''''''''''''''''''''
> > +
> > +The ``lm32`` guest CPU support is deprecated and will be removed in
> > +a future version of QEMU. The only public user of this architecture
> > +was the milkymist project, which has been dead for years; there was
> > +never an upstream Linux port.
>
> I was just looking at the current version of deprecated.rst (which has
> this patch included), and could it be that it ended up in the wrong
> section here? "lm32" is rather a softmmu target, not a linux-user mode CPU?

Yes, I think I just put it in the wrong place by mistake (ie next
to the other target deprecation notices), not noticing the top-level
section it was in.

thanks
-- PMM