qom: Use TYPE_* constants

[PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

Posted by Eduardo Habkost 5 years, 5 months ago

This will make future conversion to use OBJECT_DECLARE* easier.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org
---
 hw/pci-host/ppce500.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
index d71072731d..1a62b2f8cc 100644
--- a/hw/pci-host/ppce500.c
+++ b/hw/pci-host/ppce500.c
@@ -509,7 +509,7 @@ static void e500_host_bridge_class_init(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo e500_host_bridge_info = {
-    .name          = "e500-host-bridge",
+    .name          = TYPE_PPC_E500_PCI_BRIDGE,
     .parent        = TYPE_PCI_DEVICE,
     .instance_size = sizeof(PPCE500PCIBridgeState),
     .class_init    = e500_host_bridge_class_init,
-- 
2.26.2

Re: [PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

Posted by David Gibson 5 years, 5 months ago

On Wed, Aug 26, 2020 at 02:43:33PM -0400, Eduardo Habkost wrote:
> This will make future conversion to use OBJECT_DECLARE* easier.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: qemu-ppc@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/pci-host/ppce500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
> index d71072731d..1a62b2f8cc 100644
> --- a/hw/pci-host/ppce500.c
> +++ b/hw/pci-host/ppce500.c
> @@ -509,7 +509,7 @@ static void e500_host_bridge_class_init(ObjectClass *klass, void *data)
>  }
>  
>  static const TypeInfo e500_host_bridge_info = {
> -    .name          = "e500-host-bridge",
> +    .name          = TYPE_PPC_E500_PCI_BRIDGE,
>      .parent        = TYPE_PCI_DEVICE,
>      .instance_size = sizeof(PPCE500PCIBridgeState),
>      .class_init    = e500_host_bridge_class_init,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

Posted by Li Qiang 5 years, 5 months ago

Eduardo Habkost <ehabkost@redhat.com> 于2020年8月27日周四 上午2:51写道：
>
> This will make future conversion to use OBJECT_DECLARE* easier.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: qemu-ppc@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/pci-host/ppce500.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c
> index d71072731d..1a62b2f8cc 100644
> --- a/hw/pci-host/ppce500.c
> +++ b/hw/pci-host/ppce500.c
> @@ -509,7 +509,7 @@ static void e500_host_bridge_class_init(ObjectClass *klass, void *data)
>  }
>
>  static const TypeInfo e500_host_bridge_info = {
> -    .name          = "e500-host-bridge",
> +    .name          = TYPE_PPC_E500_PCI_BRIDGE,
>      .parent        = TYPE_PCI_DEVICE,
>      .instance_size = sizeof(PPCE500PCIBridgeState),
>      .class_init    = e500_host_bridge_class_init,
> --
> 2.26.2
>
>

[PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant
[PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant
[PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant
[PATCH 4/8] sclpconsole: Use TYPE_* constants
[PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant
[PATCH 6/8] tosa: Use TYPE_TOSA_MISC_GPIO constant
[PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant
[PATCH 8/8] dc390: Use TYPE_DC390_DEVICE constant