configure: default to PIE disabled on Windows platforms

[PATCH] configure: default to PIE disabled on Windows platforms

Posted by Daniel P. Berrangé 3 years, 8 months ago

If Windows EXE files are built with -pie/-fpie they will fail to
launch. Historically QEMU defaulted to disabling PIE for Windows,
but this setting was accidentally lost when the configure summary
text was removed in

  commit f9332757898a764d85e19d339ec421236e885b68
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   Mon Feb 3 13:28:38 2020 +0100

    meson: move summary to meson.build

    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Fixes: f9332757898a764d85e19d339ec421236e885b68
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 67832e3bab..b6f3b6e191 100755
--- a/configure
+++ b/configure
@@ -857,6 +857,7 @@ MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"
-- 
2.26.2

Re: [PATCH] configure: default to PIE disabled on Windows platforms

Posted by Marc-André Lureau 3 years, 8 months ago

Hi

On Mon, Aug 24, 2020 at 8:31 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> If Windows EXE files are built with -pie/-fpie they will fail to
> launch. Historically QEMU defaulted to disabling PIE for Windows,
> but this setting was accidentally lost when the configure summary
> text was removed in
>
>   commit f9332757898a764d85e19d339ec421236e885b68
>   Author: Paolo Bonzini <pbonzini@redhat.com>
>   Date:   Mon Feb 3 13:28:38 2020 +0100
>
>     meson: move summary to meson.build
>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Fixes: f9332757898a764d85e19d339ec421236e885b68
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>

(one of those innocent looking commits)

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 67832e3bab..b6f3b6e191 100755
> --- a/configure
> +++ b/configure
> @@ -857,6 +857,7 @@ MINGW32*)
>      audio_drv_list=""
>    fi
>    supported_os="yes"
> +  pie="no"
>  ;;
>  GNU/kFreeBSD)
>    bsd="yes"
> --
> 2.26.2
>
>
>

-- 
Marc-André Lureau

Re: [PATCH] configure: default to PIE disabled on Windows platforms

Posted by Thomas Huth 3 years, 8 months ago

On 24/08/2020 18.31, Daniel P. Berrangé wrote:
> If Windows EXE files are built with -pie/-fpie they will fail to
> launch. Historically QEMU defaulted to disabling PIE for Windows,
> but this setting was accidentally lost when the configure summary
> text was removed in
> 
>    commit f9332757898a764d85e19d339ec421236e885b68
>    Author: Paolo Bonzini <pbonzini@redhat.com>
>    Date:   Mon Feb 3 13:28:38 2020 +0100
> 
>      meson: move summary to meson.build
> 
>      Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Fixes: f9332757898a764d85e19d339ec421236e885b68
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   configure | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 67832e3bab..b6f3b6e191 100755
> --- a/configure
> +++ b/configure
> @@ -857,6 +857,7 @@ MINGW32*)
>       audio_drv_list=""
>     fi
>     supported_os="yes"
> +  pie="no"
>   ;;
>   GNU/kFreeBSD)
>     bsd="yes"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] configure: default to PIE disabled on Windows platforms

Posted by Paolo Bonzini 3 years, 8 months ago

Queued, thanks.

Paolo

Il lun 24 ago 2020, 18:31 Daniel P. Berrangé <berrange@redhat.com> ha
scritto:

> If Windows EXE files are built with -pie/-fpie they will fail to
> launch. Historically QEMU defaulted to disabling PIE for Windows,
> but this setting was accidentally lost when the configure summary
> text was removed in
>
>   commit f9332757898a764d85e19d339ec421236e885b68
>   Author: Paolo Bonzini <pbonzini@redhat.com>
>   Date:   Mon Feb 3 13:28:38 2020 +0100
>
>     meson: move summary to meson.build
>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Fixes: f9332757898a764d85e19d339ec421236e885b68
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 67832e3bab..b6f3b6e191 100755
> --- a/configure
> +++ b/configure
> @@ -857,6 +857,7 @@ MINGW32*)
>      audio_drv_list=""
>    fi
>    supported_os="yes"
> +  pie="no"
>  ;;
>  GNU/kFreeBSD)
>    bsd="yes"
> --
> 2.26.2
>
>