[PATCH] meson: Fix chardev-baum.so name

Bruce Rogers posted 1 patch 3 years, 8 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200824155236.789635-1-brogers@suse.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
chardev/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] meson: Fix chardev-baum.so name
Posted by Bruce Rogers 3 years, 8 months ago
Somehow in the conversion to meson, the module named chardev-baum got
renamed to chardev-brlapi. Change it back.

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 chardev/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/meson.build b/chardev/meson.build
index a46a6237be..7726837e34 100644
--- a/chardev/meson.build
+++ b/chardev/meson.build
@@ -39,7 +39,7 @@ chardev_modules = {}
 if config_host.has_key('CONFIG_BRLAPI') and sdl.found()
   module_ss = ss.source_set()
   module_ss.add(when: [sdl, brlapi], if_true: files('baum.c'))
-  chardev_modules += { 'brlapi': module_ss }
+  chardev_modules += { 'baum': module_ss }
 endif
 
 modules += { 'chardev': chardev_modules }
-- 
2.28.0


Re: [PATCH] meson: Fix chardev-baum.so name
Posted by Marc-André Lureau 3 years, 8 months ago
Hi

On Mon, Aug 24, 2020 at 7:53 PM Bruce Rogers <brogers@suse.com> wrote:

> Somehow in the conversion to meson, the module named chardev-baum got
> renamed to chardev-brlapi. Change it back.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  chardev/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/meson.build b/chardev/meson.build
> index a46a6237be..7726837e34 100644
> --- a/chardev/meson.build
> +++ b/chardev/meson.build
> @@ -39,7 +39,7 @@ chardev_modules = {}
>  if config_host.has_key('CONFIG_BRLAPI') and sdl.found()
>    module_ss = ss.source_set()
>    module_ss.add(when: [sdl, brlapi], if_true: files('baum.c'))
> -  chardev_modules += { 'brlapi': module_ss }
> +  chardev_modules += { 'baum': module_ss }
>  endif
>
>  modules += { 'chardev': chardev_modules }
> --
> 2.28.0
>
>
>

-- 
Marc-André Lureau
Re: [PATCH] meson: Fix chardev-baum.so name
Posted by Paolo Bonzini 3 years, 8 months ago
Queued, thanks.

Paolo

Il lun 24 ago 2020, 17:52 Bruce Rogers <brogers@suse.com> ha scritto:

> Somehow in the conversion to meson, the module named chardev-baum got
> renamed to chardev-brlapi. Change it back.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  chardev/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/meson.build b/chardev/meson.build
> index a46a6237be..7726837e34 100644
> --- a/chardev/meson.build
> +++ b/chardev/meson.build
> @@ -39,7 +39,7 @@ chardev_modules = {}
>  if config_host.has_key('CONFIG_BRLAPI') and sdl.found()
>    module_ss = ss.source_set()
>    module_ss.add(when: [sdl, brlapi], if_true: files('baum.c'))
> -  chardev_modules += { 'brlapi': module_ss }
> +  chardev_modules += { 'baum': module_ss }
>  endif
>
>  modules += { 'chardev': chardev_modules }
> --
> 2.28.0
>
>