meson: Fix shell script syntax in qemu-version.sh

[PATCH] meson: Fix shell script syntax in qemu-version.sh

Bruce Rogers posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test FreeBSD passed

Test docker-mingw@fedora failed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200824155111.789466-1-brogers@suse.com

scripts/qemu-version.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] meson: Fix shell script syntax in qemu-version.sh

Posted by Bruce Rogers 3 years, 8 months ago

There needs to be a space before the closing bracket.

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 scripts/qemu-version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
index 4847385e42..03128c56a2 100755
--- a/scripts/qemu-version.sh
+++ b/scripts/qemu-version.sh
@@ -6,7 +6,7 @@ dir="$1"
 pkgversion="$2"
 version="$3"
 
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
     cd "$dir"
     if [ -e .git ]; then
         pkgversion=$(git describe --match 'v*' --dirty | echo "")
-- 
2.28.0

Re: [PATCH] meson: Fix shell script syntax in qemu-version.sh

Posted by Eric Blake 3 years, 8 months ago

On 8/24/20 10:51 AM, Bruce Rogers wrote:
> There needs to be a space before the closing bracket.
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>   scripts/qemu-version.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Duplicate of 
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg05549.html

> 
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
>   pkgversion="$2"
>   version="$3"
>   
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
>       cd "$dir"
>       if [ -e .git ]; then
>           pkgversion=$(git describe --match 'v*' --dirty | echo "")
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org