meson: avoid compiling qemu-keymap by default

[PATCH v2 0/2] meson: avoid compiling qemu-keymap by default

Laurent Vivier posted 2 patches 3 years, 8 months ago

Download series mbox

Test docker-mingw@fedora failed

Test docker-quick@centos7 failed

Test checkpatch passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200824152430.1844159-1-laurent@vivier.eu

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

configure         | 29 ++++-------------------------
meson.build       | 16 +++++++++++-----
meson_options.txt |  1 +
ui/meson.build    |  2 +-
4 files changed, 17 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH v2 0/2] meson: avoid compiling qemu-keymap by default

Posted by Laurent Vivier 3 years, 8 months ago

We don't need it with linux-user only build, and if xkbcommon dynamic
library is detected it can break the build of static only binaries.

So disable it if it is no explicitly asked by the user when neither
system or tools are built.

build qemu-keymap:
  configure --disable-system --disable-tools --disable-user --enable-xkbcommon
  configure --disable-system --enable-tools --disable-user
  configure --enable-system --disable-tools --disable-user

don't build qemu-keymap:
  configure --disable-system --disable-tools --disable-user
  configure --disable-system --disable-tools --enable-user

Laurent Vivier (2):
  meson: move xkbcommon to meson
  meson: avoid compiling qemu-keymap by default

 configure         | 29 ++++-------------------------
 meson.build       | 16 +++++++++++-----
 meson_options.txt |  1 +
 ui/meson.build    |  2 +-
 4 files changed, 17 insertions(+), 31 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/2] meson: avoid compiling qemu-keymap by default

Posted by Paolo Bonzini 3 years, 8 months ago

Queued, thanks.

Paolo

Il lun 24 ago 2020, 17:24 Laurent Vivier <laurent@vivier.eu> ha scritto:

> We don't need it with linux-user only build, and if xkbcommon dynamic
> library is detected it can break the build of static only binaries.
>
> So disable it if it is no explicitly asked by the user when neither
> system or tools are built.
>
> build qemu-keymap:
>   configure --disable-system --disable-tools --disable-user
> --enable-xkbcommon
>   configure --disable-system --enable-tools --disable-user
>   configure --enable-system --disable-tools --disable-user
>
> don't build qemu-keymap:
>   configure --disable-system --disable-tools --disable-user
>   configure --disable-system --disable-tools --enable-user
>
> Laurent Vivier (2):
>   meson: move xkbcommon to meson
>   meson: avoid compiling qemu-keymap by default
>
>  configure         | 29 ++++-------------------------
>  meson.build       | 16 +++++++++++-----
>  meson_options.txt |  1 +
>  ui/meson.build    |  2 +-
>  4 files changed, 17 insertions(+), 31 deletions(-)
>
> --
> 2.26.2
>
>
>