scripts/qemu-version.sh: Add missing space before ']'

[PATCH] scripts/qemu-version.sh: Add missing space before ']'

Posted by Thomas Huth 3 years, 8 months ago

When configure has been run with --with-pkgversion=xyz, the shell complains
about a missing ']' in this script.

Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 scripts/qemu-version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
index 4847385e42..03128c56a2 100755
--- a/scripts/qemu-version.sh
+++ b/scripts/qemu-version.sh
@@ -6,7 +6,7 @@ dir="$1"
 pkgversion="$2"
 version="$3"
 
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
     cd "$dir"
     if [ -e .git ]; then
         pkgversion=$(git describe --match 'v*' --dirty | echo "")
-- 
2.18.2

Re: [PATCH] scripts/qemu-version.sh: Add missing space before ']'

Posted by Marc-André Lureau 3 years, 8 months ago

Hi

On Sun, Aug 23, 2020 at 2:26 PM Thomas Huth <thuth@redhat.com> wrote:
>
> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth <thuth@redhat.com>

oops, my bad

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  scripts/qemu-version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
>  pkgversion="$2"
>  version="$3"
>
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
>      cd "$dir"
>      if [ -e .git ]; then
>          pkgversion=$(git describe --match 'v*' --dirty | echo "")
> --
> 2.18.2
>

Re: [PATCH] scripts/qemu-version.sh: Add missing space before ']'

Posted by Paolo Bonzini 3 years, 8 months ago

Queued, thanks.

Paolo

Il dom 23 ago 2020, 12:26 Thomas Huth <thuth@redhat.com> ha scritto:

> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  scripts/qemu-version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
>  pkgversion="$2"
>  version="$3"
>
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
>      cd "$dir"
>      if [ -e .git ]; then
>          pkgversion=$(git describe --match 'v*' --dirty | echo "")
> --
> 2.18.2
>
>