[v2] util/hexdump: Cleanup qemu_hexdump()

[PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Philippe Mathieu-Daudé posted 2 patches 3 years, 8 months ago

Diff against v1
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200822180950.1343963-1-f4bug@amsat.org

include/qemu-common.h    |  3 ++-
hw/dma/xlnx_dpdma.c      |  2 +-
hw/net/fsl_etsec/etsec.c |  2 +-
hw/net/fsl_etsec/rings.c |  2 +-
hw/sd/sd.c               |  2 +-
hw/usb/redirect.c        |  2 +-
net/colo-compare.c       | 24 ++++++++++++------------
net/net.c                |  2 +-
util/hexdump.c           |  4 +++-
util/iov.c               |  2 +-
10 files changed, 24 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

- Pass const void* buffer
- Reorder arguments

Supersedes: <20200822150457.1322519-1-f4bug@amsat.org>

Philippe Mathieu-Daudé (2):
  util/hexdump: Convert to take a void pointer argument
  util/hexdump: Reorder qemu_hexdump() arguments

 include/qemu-common.h    |  3 ++-
 hw/dma/xlnx_dpdma.c      |  2 +-
 hw/net/fsl_etsec/etsec.c |  2 +-
 hw/net/fsl_etsec/rings.c |  2 +-
 hw/sd/sd.c               |  2 +-
 hw/usb/redirect.c        |  2 +-
 net/colo-compare.c       | 24 ++++++++++++------------
 net/net.c                |  2 +-
 util/hexdump.c           |  4 +++-
 util/iov.c               |  2 +-
 10 files changed, 24 insertions(+), 21 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Posted by Stefano Garzarella 3 years, 8 months ago

On Sat, Aug 22, 2020 at 08:09:48PM +0200, Philippe Mathieu-DaudÃ© wrote:
> - Pass const void* buffer
> - Reorder arguments
> 
> Supersedes: <20200822150457.1322519-1-f4bug@amsat.org>
> 
> Philippe Mathieu-DaudÃ© (2):
>   util/hexdump: Convert to take a void pointer argument
>   util/hexdump: Reorder qemu_hexdump() arguments
> 
>  include/qemu-common.h    |  3 ++-
>  hw/dma/xlnx_dpdma.c      |  2 +-
>  hw/net/fsl_etsec/etsec.c |  2 +-
>  hw/net/fsl_etsec/rings.c |  2 +-
>  hw/sd/sd.c               |  2 +-
>  hw/usb/redirect.c        |  2 +-
>  net/colo-compare.c       | 24 ++++++++++++------------
>  net/net.c                |  2 +-
>  util/hexdump.c           |  4 +++-
>  util/iov.c               |  2 +-
>  10 files changed, 24 insertions(+), 21 deletions(-)
> 
> -- 
> 2.26.2
> 
> 

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Posted by Jason Wang 3 years, 8 months ago

On 2020/8/23 上午2:09, Philippe Mathieu-Daudé wrote:
> - Pass const void* buffer
> - Reorder arguments
>
> Supersedes: <20200822150457.1322519-1-f4bug@amsat.org>
>
> Philippe Mathieu-Daudé (2):
>    util/hexdump: Convert to take a void pointer argument
>    util/hexdump: Reorder qemu_hexdump() arguments
>
>   include/qemu-common.h    |  3 ++-
>   hw/dma/xlnx_dpdma.c      |  2 +-
>   hw/net/fsl_etsec/etsec.c |  2 +-
>   hw/net/fsl_etsec/rings.c |  2 +-
>   hw/sd/sd.c               |  2 +-
>   hw/usb/redirect.c        |  2 +-
>   net/colo-compare.c       | 24 ++++++++++++------------
>   net/net.c                |  2 +-
>   util/hexdump.c           |  4 +++-
>   util/iov.c               |  2 +-
>   10 files changed, 24 insertions(+), 21 deletions(-)
>

Applied.

Thanks

Re: [PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

Hi Laurent,

On 8/22/20 8:09 PM, Philippe Mathieu-Daudé wrote:
> - Pass const void* buffer
> - Reorder arguments
> 
> Supersedes: <20200822150457.1322519-1-f4bug@amsat.org>
> 
> Philippe Mathieu-Daudé (2):
>   util/hexdump: Convert to take a void pointer argument
>   util/hexdump: Reorder qemu_hexdump() arguments

This series is fully reviewed, can it go via
your qemu-trivial tree?

Thanks,

Phil.

Re: [PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

Posted by Laurent Vivier 3 years, 7 months ago

Le 11/09/2020 à 16:35, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
> 
> On 8/22/20 8:09 PM, Philippe Mathieu-Daudé wrote:
>> - Pass const void* buffer
>> - Reorder arguments
>>
>> Supersedes: <20200822150457.1322519-1-f4bug@amsat.org>
>>
>> Philippe Mathieu-Daudé (2):
>>   util/hexdump: Convert to take a void pointer argument
>>   util/hexdump: Reorder qemu_hexdump() arguments
> 
> This series is fully reviewed, can it go via
> your qemu-trivial tree?

Done.

Thanks,
Laurent