hw/ssi/ssi: Set abstract TYPE_SSI_SLAVE instance size

[PATCH] hw/ssi/ssi: Set abstract TYPE_SSI_SLAVE instance size

Philippe Mathieu-Daudé posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200821174604.1264321-1-f4bug@amsat.org

hw/ssi/ssi.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/ssi/ssi: Set abstract TYPE_SSI_SLAVE instance size

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

Set the abstract TYPE_SSI_SLAVE instance size in case an
implementation forgot to set it.

Reported-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
See:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg731954.html
---
 hw/ssi/ssi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c
index a35d7ebb266..b3e82470381 100644
--- a/hw/ssi/ssi.c
+++ b/hw/ssi/ssi.c
@@ -85,6 +85,7 @@ static void ssi_slave_class_init(ObjectClass *klass, void *data)
 static const TypeInfo ssi_slave_info = {
     .name = TYPE_SSI_SLAVE,
     .parent = TYPE_DEVICE,
+    .instance_size = sizeof(SSISlave),
     .class_init = ssi_slave_class_init,
     .class_size = sizeof(SSISlaveClass),
     .abstract = true,
-- 
2.26.2

Re: [PATCH] hw/ssi/ssi: Set abstract TYPE_SSI_SLAVE instance size

Posted by Alistair Francis 3 years, 8 months ago

On Fri, Aug 21, 2020 at 10:46 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Set the abstract TYPE_SSI_SLAVE instance size in case an
> implementation forgot to set it.
>
> Reported-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
> See:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg731954.html
> ---
>  hw/ssi/ssi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c
> index a35d7ebb266..b3e82470381 100644
> --- a/hw/ssi/ssi.c
> +++ b/hw/ssi/ssi.c
> @@ -85,6 +85,7 @@ static void ssi_slave_class_init(ObjectClass *klass, void *data)
>  static const TypeInfo ssi_slave_info = {
>      .name = TYPE_SSI_SLAVE,
>      .parent = TYPE_DEVICE,
> +    .instance_size = sizeof(SSISlave),
>      .class_init = ssi_slave_class_init,
>      .class_size = sizeof(SSISlaveClass),
>      .abstract = true,
> --
> 2.26.2
>
>