target/s390x: fix meson.build issue

[PATCH] target/s390x: fix meson.build issue

Paolo Bonzini posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200821155249.24304-1-pbonzini@redhat.com

Maintainers: David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, Thomas Huth <thuth@redhat.com>

target/s390x/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] target/s390x: fix meson.build issue

Posted by Paolo Bonzini 3 years, 8 months ago

files() is needed to avoid

../meson.build:977:2: ERROR: File tcg-stub.c does not exist.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/s390x/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/s390x/meson.build b/target/s390x/meson.build
index d2a3315903..c42eadb7d2 100644
--- a/target/s390x/meson.build
+++ b/target/s390x/meson.build
@@ -21,7 +21,7 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
   'vec_helper.c',
   'vec_int_helper.c',
   'vec_string_helper.c',
-), if_false: 'tcg-stub.c')
+), if_false: files('tcg-stub.c'))
 
 s390x_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
 
-- 
2.26.2

Re: [PATCH] target/s390x: fix meson.build issue

Posted by Philippe Mathieu-Daudé 3 years, 8 months ago

On 8/21/20 5:52 PM, Paolo Bonzini wrote:
> files() is needed to avoid
> 
> ../meson.build:977:2: ERROR: File tcg-stub.c does not exist.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  target/s390x/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/meson.build b/target/s390x/meson.build
> index d2a3315903..c42eadb7d2 100644
> --- a/target/s390x/meson.build
> +++ b/target/s390x/meson.build
> @@ -21,7 +21,7 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
>    'vec_helper.c',
>    'vec_int_helper.c',
>    'vec_string_helper.c',
> -), if_false: 'tcg-stub.c')
> +), if_false: files('tcg-stub.c'))
>  
>  s390x_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
>  

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>