[v1] ui: Add more mouse buttons to SPICE

[PATCH] ui: Add more mouse buttons to SPICE

Frediano Ziglio posted 1 patch 3 years, 8 months ago

Diff against v1 v1
Download mbox

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200820130008.43754-1-fziglio@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

There is a newer version of this series

ui/spice-input.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] ui: Add more mouse buttons to SPICE

Posted by Frediano Ziglio 3 years, 8 months ago

From: Frediano Ziglio <freddy77@gmail.com>

Add support for SIDE and EXTRA buttons.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
---
 ui/spice-input.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/spice-input.c b/ui/spice-input.c
index cd4bb0043f..d5bba231c9 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -123,6 +123,8 @@ static void spice_update_buttons(QemuSpicePointer *pointer,
         [INPUT_BUTTON_RIGHT]       = 0x02,
         [INPUT_BUTTON_WHEEL_UP]    = 0x10,
         [INPUT_BUTTON_WHEEL_DOWN]  = 0x20,
+        [INPUT_BUTTON_SIDE]        = 0x40,
+        [INPUT_BUTTON_EXTRA]       = 0x80,
     };
 
     if (wheel < 0) {
-- 
2.25.4

Re: [PATCH] ui: Add more mouse buttons to SPICE

Posted by Marc-André Lureau 3 years, 8 months ago

Hi

On Thu, Aug 20, 2020 at 5:01 PM Frediano Ziglio <fziglio@redhat.com> wrote:

> From: Frediano Ziglio <freddy77@gmail.com>
>
> Add support for SIDE and EXTRA buttons.
>
> Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
> ---
>  ui/spice-input.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index cd4bb0043f..d5bba231c9 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -123,6 +123,8 @@ static void spice_update_buttons(QemuSpicePointer
> *pointer,
>          [INPUT_BUTTON_RIGHT]       = 0x02,
>          [INPUT_BUTTON_WHEEL_UP]    = 0x10,
>          [INPUT_BUTTON_WHEEL_DOWN]  = 0x20,
> +        [INPUT_BUTTON_SIDE]        = 0x40,
> +        [INPUT_BUTTON_EXTRA]       = 0x80,
>      };
>
>      if (wheel < 0) {
> --
> 2.25.4
>
>
I don't see where those values are defined, can you describe it a bit?

thanks


-- 
Marc-André Lureau