[PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro

Eduardo Habkost posted 58 patches 5 years, 5 months ago
There is a newer version of this series
[PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro
Posted by Eduardo Habkost 5 years, 5 months ago
The macro never worked because the NubusBridge typedef doesn't
exist.  Delete it.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2: none

---
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org
---
 include/hw/nubus/nubus.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
index a8634e54c5..c350948262 100644
--- a/include/hw/nubus/nubus.h
+++ b/include/hw/nubus/nubus.h
@@ -29,7 +29,6 @@
 #define NUBUS_BUS(obj) OBJECT_CHECK(NubusBus, (obj), TYPE_NUBUS_BUS)
 
 #define TYPE_NUBUS_BRIDGE "nubus-bridge"
-#define NUBUS_BRIDGE(obj) OBJECT_CHECK(NubusBridge, (obj), TYPE_NUBUS_BRIDGE)
 
 typedef struct NubusBus {
     BusState qbus;
-- 
2.26.2


Re: [PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro
Posted by Laurent Vivier 5 years, 5 months ago
Le 20/08/2020 à 02:12, Eduardo Habkost a écrit :
> The macro never worked because the NubusBridge typedef doesn't
> exist.  Delete it.
> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2: none
> 
> ---
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: qemu-devel@nongnu.org
> ---
>  include/hw/nubus/nubus.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
> index a8634e54c5..c350948262 100644
> --- a/include/hw/nubus/nubus.h
> +++ b/include/hw/nubus/nubus.h
> @@ -29,7 +29,6 @@
>  #define NUBUS_BUS(obj) OBJECT_CHECK(NubusBus, (obj), TYPE_NUBUS_BUS)
>  
>  #define TYPE_NUBUS_BRIDGE "nubus-bridge"
> -#define NUBUS_BRIDGE(obj) OBJECT_CHECK(NubusBridge, (obj), TYPE_NUBUS_BRIDGE)
>  
>  typedef struct NubusBus {
>      BusState qbus;
> 

Acked-by: Laurent Vivier <laurent@vivier.eu>