On 8/25/20 8:01 AM, Joel Stanley wrote:
> On Wed, 19 Aug 2020 at 10:10, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> Hello,
>>
>> This series includes various fixes improving the support of Aspeed
>> machines. Extra attention was given to the robustness of the ftgmac100
>> model. A small kernel module tester was created for this purpose :
>>
>> https://github.com/legoater/ftgmac100-test/
>
> I gave this a test and it successfully broke the machine for me
> without your fixes.
The network stack is busted. yes. Sometimes it survives or does a reset.
HW always survives which is surprising.
Thanks,
C.
> I tried to test this series but the new build system stopped me from
> being able to complete a build. It failed with:
>
> Found ninjatool-1.8 at qemu/upstream/build/ninjatool
> ./ninjatool -t ninja2make --omit clean dist uninstall < build.ninja >
> Makefile.ninja
> /bin/sh: build.ninja: No such file or directory
>
> :(
>
>>
>> Changes in v2 :
>>
>> - definitions for some new flash models in m25p80 by Igor
>> - All Joel's comments should have been addressed
>> - A better fix of the integer overflow in ftgmac100_do_tx suggested
>> by Peter.
>>
>>
>> This needs a couple more reviewed-by before I can send a PR.
>
> I have read through all the patches and I have no objections.
>
> Cheers,
>
> Joel
>
>>
>> Thanks,
>>
>> C.
>>
>> Cédric Le Goater (16):
>> m25p80: Return the JEDEC ID twice for mx25l25635e
>> m25p80: Add support for mx25l25635f
>> m25p80: Add support for n25q512ax3
>> aspeed/scu: Fix valid access size on AST2400
>> aspeed/smc: Fix MemoryRegionOps definition
>> aspeed/smc: Fix max_slaves of the legacy SMC device
>> aspeed/sdhci: Fix reset sequence
>> ftgmac100: Fix registers that can be read
>> ftgmac100: Fix interrupt status "Packet transmitted on ethernet"
>> ftgmac100: Fix interrupt status "Packet moved to RX FIFO"
>> ftgmac100: Change interrupt status when a DMA error occurs
>> ftgmac100: Check for invalid len and address before doing a DMA
>> transfer
>> ftgmac100: Fix integer overflow in ftgmac100_do_tx()
>> ftgmac100: Improve software reset
>> aspeed/sdmc: Simplify calculation of RAM bits
>> aspeed/smc: Open AHB window of the second chip of the AST2600 FMC
>> controller
>>
>> Igor Kononenko (2):
>> arm: aspeed: add strap define `25HZ` of AST2500
>> hw: add a number of SPI-flash's of m25p80 family
>>
>> Joel Stanley (2):
>> aspeed/sdmc: Perform memory training
>> aspeed/sdmc: Allow writes to unprotected registers
>>
>> erik-smit (1):
>> hw/arm/aspeed: Add board model for Supermicro X11 BMC
>>
>> include/hw/misc/aspeed_scu.h | 1 +
>> include/hw/misc/aspeed_sdmc.h | 13 +++-
>> hw/arm/aspeed.c | 35 ++++++++++
>> hw/block/m25p80.c | 6 +-
>> hw/misc/aspeed_scu.c | 9 +--
>> hw/misc/aspeed_sdmc.c | 125 +++++++++++++++++++---------------
>> hw/net/ftgmac100.c | 95 ++++++++++++++++++--------
>> hw/sd/aspeed_sdhci.c | 14 +++-
>> hw/ssi/aspeed_smc.c | 6 +-
>> 9 files changed, 209 insertions(+), 95 deletions(-)
>>
>> --
>> 2.25.4
>>