[v1] Tracing patches

[PULL 0/9] Tracing patches

Posted by Stefan Hajnoczi 3 years, 8 months ago

The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:

  Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)

are available in the Git repository at:

  https://github.com/stefanha/qemu.git tags/tracing-pull-request

for you to fetch changes up to bd6c9e56aba2e1b9a307642c72375386afbcf1f2:

  trace-events: Fix attribution of trace points to source (2020-08-12 20:28:5=
4 +0100)

----------------------------------------------------------------
Pull request

macOS dtrace support and cleanups.

----------------------------------------------------------------

Markus Armbruster (4):
  scripts/cleanup-trace-events: Fix for vcpu property
  scripts/cleanup-trace-events: Emit files in alphabetical order
  trace-events: Delete unused trace points
  trace-events: Fix attribution of trace points to source

Philippe Mathieu-Daud=C3=A9 (1):
  softmmu: Add missing trace-events file

Roman Bolshakov (4):
  scripts/tracetool: Fix dtrace generation for macOS
  scripts/tracetool: Use void pointer for vcpu
  build: Don't make object files for dtrace on macOS
  net/colo: Match is-enabled probe to tracepoint

 Makefile.objs                   |  3 +++
 net/colo-compare.c              | 42 +++++++++++++++++----------------
 net/filter-rewriter.c           | 10 ++++++--
 softmmu/balloon.c               |  2 +-
 softmmu/ioport.c                |  2 +-
 softmmu/memory.c                |  2 +-
 softmmu/vl.c                    |  2 +-
 audio/trace-events              |  3 ---
 block/trace-events              |  8 ++-----
 hw/block/trace-events           |  2 +-
 hw/char/trace-events            |  2 +-
 hw/display/trace-events         |  4 +++-
 hw/hyperv/trace-events          |  2 +-
 hw/mips/trace-events            |  2 +-
 hw/misc/trace-events            |  9 +++----
 hw/ppc/trace-events             | 10 ++------
 hw/riscv/trace-events           |  2 +-
 hw/rtc/trace-events             |  2 +-
 hw/timer/trace-events           |  1 -
 hw/tpm/trace-events             |  2 +-
 hw/usb/trace-events             |  4 +++-
 hw/vfio/trace-events            | 10 ++++----
 hw/virtio/trace-events          |  2 +-
 migration/trace-events          | 37 +++++++++++++++--------------
 net/trace-events                |  2 --
 scripts/cleanup-trace-events.pl | 23 +++++++++++-------
 scripts/tracetool/format/d.py   | 15 +++++++++++-
 scripts/tracetool/vcpu.py       |  2 +-
 softmmu/trace-events            | 28 ++++++++++++++++++++++
 target/ppc/trace-events         |  1 -
 target/riscv/trace-events       |  2 +-
 trace-events                    | 32 +++----------------------
 ui/trace-events                 |  6 ++---
 util/trace-events               |  4 +++-
 34 files changed, 152 insertions(+), 128 deletions(-)
 create mode 100644 softmmu/trace-events

--=20
2.26.2

Re: [PULL 0/9] Tracing patches

Posted by no-reply@patchew.org 3 years, 8 months ago

Patchew URL: https://patchew.org/QEMU/20200813052257.226142-1-stefanha@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200813052257.226142-1-stefanha@redhat.com
Subject: [PULL 0/9] Tracing patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ab1e0e0 trace-events: Fix attribution of trace points to source
b4e6c94 trace-events: Delete unused trace points
967b100 scripts/cleanup-trace-events: Emit files in alphabetical order
a3b5483 scripts/cleanup-trace-events: Fix for vcpu property
c846bf7 softmmu: Add missing trace-events file
63d5982 net/colo: Match is-enabled probe to tracepoint
75eab42 build: Don't make object files for dtrace on macOS
28b2951 scripts/tracetool: Use void pointer for vcpu
dc44f9f scripts/tracetool: Fix dtrace generation for macOS

=== OUTPUT BEGIN ===
1/9 Checking commit dc44f9f395ff (scripts/tracetool: Fix dtrace generation for macOS)
2/9 Checking commit 28b2951555cd (scripts/tracetool: Use void pointer for vcpu)
3/9 Checking commit 75eab42de18c (build: Don't make object files for dtrace on macOS)
4/9 Checking commit 63d598213058 (net/colo: Match is-enabled probe to tracepoint)
5/9 Checking commit c846bf7afef4 (softmmu: Add missing trace-events file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#76: 
new file mode 100644

total: 0 errors, 1 warnings, 111 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit a3b5483d4283 (scripts/cleanup-trace-events: Fix for vcpu property)
ERROR: code indent should never use tabs
#33: FILE: scripts/cleanup-trace-events.pl:38:
+^I    defined $3 ? () : ('--max-depth', '1'),$

ERROR: code indent should never use tabs
#34: FILE: scripts/cleanup-trace-events.pl:39:
+^I    $pat$

total: 2 errors, 0 warnings, 16 lines checked

Patch 6/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/9 Checking commit 967b100f8520 (scripts/cleanup-trace-events: Emit files in alphabetical order)
8/9 Checking commit b4e6c94dad64 (trace-events: Delete unused trace points)
9/9 Checking commit ab1e0e0ff43d (trace-events: Fix attribution of trace points to source)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200813052257.226142-1-stefanha@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 0/9] Tracing patches

Posted by Peter Maydell 3 years, 8 months ago

On Thu, 13 Aug 2020 at 08:44, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
>   Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to bd6c9e56aba2e1b9a307642c72375386afbcf1f2:
>
>   trace-events: Fix attribution of trace points to source (2020-08-12 20:28:5=
> 4 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> macOS dtrace support and cleanups.

Hi; this conflicts with the meson buildsystem merge, I'm
afraid -- can you rebase and resend, please?

thanks
-- PMM

Re: [PULL 0/9] Tracing patches

Posted by Stefan Hajnoczi 3 years, 7 months ago

On Fri, Aug 21, 2020 at 5:26 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 13 Aug 2020 at 08:44, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
> >
> >   Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/stefanha/qemu.git tags/tracing-pull-request
> >
> > for you to fetch changes up to bd6c9e56aba2e1b9a307642c72375386afbcf1f2:
> >
> >   trace-events: Fix attribution of trace points to source (2020-08-12 20:28:5=
> > 4 +0100)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > macOS dtrace support and cleanups.
>
> Hi; this conflicts with the meson buildsystem merge, I'm
> afraid -- can you rebase and resend, please?

Sure, I will resend it.

Stefan

Re: [PULL 0/9] Tracing patches

Posted by no-reply@patchew.org 3 years, 8 months ago

Patchew URL: https://patchew.org/QEMU/20200813052257.226142-1-stefanha@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TEST    check-unit: tests/test-char
Unexpected error in object_property_try_add() at /tmp/qemu-test/src/qom/object.c:1181:
attempt to add duplicate property 'serial-id' to object (type 'container')
ERROR test-char - too few tests run (expected 38, got 9)
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs....
qemu-system-aarch64: -accel kvm: invalid accelerator kvm
qemu-system-aarch64: falling back to tcg
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=5808c97c711e485db979e5289207613b', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-wo4v6nnp/src/docker-src.2020-08-13-06.32.42.31813:/var/tmp/qemu:z,ro', 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=5808c97c711e485db979e5289207613b
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wo4v6nnp/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    14m32.450s
user    0m8.381s


The full log is available at
http://patchew.org/logs/20200813052257.226142-1-stefanha@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 0/9] Tracing patches

Posted by Stefan Hajnoczi 3 years, 8 months ago

On Thu, Aug 13, 2020 at 03:47:16AM -0700, no-reply@patchew.org wrote:
>   TEST    check-unit: tests/test-char
> Unexpected error in object_property_try_add() at /tmp/qemu-test/src/qom/object.c:1181:
> attempt to add duplicate property 'serial-id' to object (type 'container')
> ERROR test-char - too few tests run (expected 38, got 9)

Pre-existing issue. This error is also affecting other patch series.

Stefan