target-hppa fixes pull request v2

[PULL v2 00/12] target-hppa fixes pull request v2

Posted by Helge Deller 3 years, 8 months ago

Please pull from
    https://github.com/hdeller/qemu-hppa.git target-hppa
to fix those bugs in target-hppa:

* Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian

* Fix the SeaBIOS-hppa firmware to boot NetBSD again

* Fix many artist framebuffer out-of-bounds accesses as found by Alexander Bulekov

* Fix artist memory access bugs due to commit 5d971f9e6725 ("memory: Revert
  "memory: accept mismatching sizes in memory_region_access_valid")

* Fix various artist screen updates when running dtwm on HP-UX

In addition the SeaBIOS-hppa firmware now includes a version check to prevent
starting when it's incompatible to the emulated qemu hardware.

Thanks,
Helge

----------------------------------------------------------------
Changes to v3:
* Fix memory fallouts due to commit 5d971f9e6725
* Fix graphic rendering bugs and screen refreshes with dtwm on HP-UX

Changes to v2:
* added more Acks by Richard Henderson
* added more artist framebuffer out-of-bounds fixes by
  Philippe Mathieu-Daudé which were reported by Alexander Bulekov
* fix NetBSD boot

Changes to v1:
* added Ack by Richard Henderson for the first patch
* revised out of bounds check based on Richards feedback

Helge Deller (7):
  hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources
  seabios-hppa: Update to SeaBIOS hppa version 1
  hw/hppa: Implement proper SeaBIOS version check
  hw/hppa/lasi: Don't abort on invalid IMR value
  Revert "hw/display/artist: Avoid drawing line when nothing to display"
  hw/display/artist: Prevent out of VRAM buffer accesses
  hw/display/artist: Unbreak size mismatch memory accesses

Philippe Mathieu-Daudé (2):
  hw/display/artist: Check offset in draw_line to avoid buffer over-run
  hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

Sven Schnelle (3):
  hw/display/artist.c: fix out of bounds check
  hw/display/artist: Fix invalidation of lines in artist_draw_line()
  hw/display/artist: Fix invalidation of lines near screen border

 hw/display/artist.c       | 186 +++++++++++++++++++++++---------------
 hw/hppa/hppa_hardware.h   |   6 ++
 hw/hppa/lasi.c            |   9 +-
 hw/hppa/machine.c         |  22 +++++
 pc-bios/hppa-firmware.img | Bin 766136 -> 783192 bytes
 roms/seabios-hppa         |   2 +-
 6 files changed, 148 insertions(+), 77 deletions(-)

--
2.21.3

Re: [PULL v2 00/12] target-hppa fixes pull request v2

Posted by Peter Maydell 3 years, 8 months ago

On Mon, 10 Aug 2020 at 14:24, Helge Deller <deller@gmx.de> wrote:
>
> Please pull from
>     https://github.com/hdeller/qemu-hppa.git target-hppa
> to fix those bugs in target-hppa:
>
> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>
> * Fix the SeaBIOS-hppa firmware to boot NetBSD again
>
> * Fix many artist framebuffer out-of-bounds accesses as found by Alexander Bulekov
>
> * Fix artist memory access bugs due to commit 5d971f9e6725 ("memory: Revert
>   "memory: accept mismatching sizes in memory_region_access_valid")
>
> * Fix various artist screen updates when running dtwm on HP-UX
>
> In addition the SeaBIOS-hppa firmware now includes a version check to prevent
> starting when it's incompatible to the emulated qemu hardware.

We're currently in the final stages of freeze for 5.1.
I'm not taking anything except point fixes for absolutely
release critical bugs until after 5.1 is out. I'll come
back and apply this for 5.2 after that.

thanks
-- PMM

Re: [PULL v2 00/12] target-hppa fixes pull request v2

Posted by Peter Maydell 3 years, 8 months ago

On Mon, 10 Aug 2020 at 14:24, Helge Deller <deller@gmx.de> wrote:
>
> Please pull from
>     https://github.com/hdeller/qemu-hppa.git target-hppa
> to fix those bugs in target-hppa:
>
> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>
> * Fix the SeaBIOS-hppa firmware to boot NetBSD again
>
> * Fix many artist framebuffer out-of-bounds accesses as found by Alexander Bulekov
>
> * Fix artist memory access bugs due to commit 5d971f9e6725 ("memory: Revert
>   "memory: accept mismatching sizes in memory_region_access_valid")
>
> * Fix various artist screen updates when running dtwm on HP-UX
>
> In addition the SeaBIOS-hppa firmware now includes a version check to prevent
> starting when it's incompatible to the emulated qemu hardware.

Hi; this (via the tag target-hppa-v2-pull-request) has
a format string issue on windows and 32bit:

In file included from ../../hw/hppa/lasi.c:14:0:
../../hw/hppa/lasi.c: In function 'lasi_chip_write_with_attrs':
../../hw/hppa/lasi.c:177:17: error: format '%lx' expects argument of
type 'long unsigned int', but argument 2 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                 "LASI: tried to set invalid %lx IMR value.\n", val);
                 ^
/home/peter.maydell/qemu/include/qemu/log.h:120:22: note: in
definition of macro 'qemu_log_mask'
             qemu_log(FMT, ## __VA_ARGS__);              \
                      ^~~

PS: also I've just noticed that your pullreq email doesn't
have the standard git request-pull cover letter phrasing;
if you don't use that then my email filters will not notice
your pullreqs.

https://wiki.qemu.org/Contribute/SubmitAPullRequest is worth
reading if you haven't found it already.

thanks
-- PMM