1. Patchew
  2. QEMU
  3. View series

[RFC PATCH] travis.yml: Drop the default softmmu builds

Thomas Huth posted 1 patch 5 years, 3 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200805185403.15227-1-thuth@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Fam Zheng <fam@euphon.net>
.travis.yml | 14 --------------
1 file changed, 14 deletions(-)
[RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Thomas Huth 5 years, 3 months ago 
The total runtime of all Travis jobs is very long and we are testing
all softmmu targets in the gitlab-CI already - so we can speed up the
Travis testing a little bit by not testing the softmmu targets here
anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Well, ok, we do not test all the softmmu targets on gitlab-CI with
 that same ancient version of Ubuntu ... but do we still care about
 testing all softmmut targets on Ubuntu Xenial at all? ... at least
 according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 6695c0620f..18290bc51d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:
-- 
2.18.1
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Daniel P. Berrangé 5 years, 2 months ago 
On Wed, Aug 05, 2020 at 08:54:03PM +0200, Thomas Huth wrote:
> The total runtime of all Travis jobs is very long and we are testing
> all softmmu targets in the gitlab-CI already - so we can speed up the
> Travis testing a little bit by not testing the softmmu targets here
> anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>  that same ancient version of Ubuntu ... but do we still care about
>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>  according to our support policy, we do not care about Xenial anymore.

Yep, we explicitly don't care about Xenial. Even if we did care about
Xenial, we could put such a job on GitLab CI instead.

IIUC, the main unique feature wrt Travis vs GitLab are potential for
non-x86 hardware testing, and functional use of KVM. So if the job
isn't using one of the unique Travis features, we should cull it
from Travis and GitLab if the job is still appicable.

>  .travis.yml | 14 --------------
>  1 file changed, 14 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago 
On 9/16/20 3:16 PM, Daniel P. Berrangé wrote:
> On Wed, Aug 05, 2020 at 08:54:03PM +0200, Thomas Huth wrote:
>> The total runtime of all Travis jobs is very long and we are testing
>> all softmmu targets in the gitlab-CI already - so we can speed up the
>> Travis testing a little bit by not testing the softmmu targets here
>> anymore.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>  that same ancient version of Ubuntu ... but do we still care about
>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>  according to our support policy, we do not care about Xenial anymore.
> 
> Yep, we explicitly don't care about Xenial. Even if we did care about
> Xenial, we could put such a job on GitLab CI instead.
> 
> IIUC, the main unique feature wrt Travis vs GitLab are potential for
> non-x86 hardware testing, and functional use of KVM. So if the job
> isn't using one of the unique Travis features, we should cull it
> from Travis and GitLab if the job is still appicable.

Agreed.

Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
(Sorry for missing this patch)

> 
>>  .travis.yml | 14 --------------
>>  1 file changed, 14 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> 
> 
> Regards,
> Daniel
>
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Thomas Huth 5 years, 2 months ago 
On 05/08/2020 20.54, Thomas Huth wrote:
> The total runtime of all Travis jobs is very long and we are testing
> all softmmu targets in the gitlab-CI already - so we can speed up the
> Travis testing a little bit by not testing the softmmu targets here
> anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>  that same ancient version of Ubuntu ... but do we still care about
>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>  according to our support policy, we do not care about Xenial anymore.
> 
>  .travis.yml | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 6695c0620f..18290bc51d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -123,20 +123,6 @@ jobs:
>          - CONFIG="--disable-system --static"
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>  
> -
> -    # we split the system builds as it takes a while to build them all
> -    - name: "GCC (main-softmmu)"
> -      env:
> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> -
> -
> -    - name: "GCC (other-softmmu)"
> -      env:
> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> -
> -
>      # Just build tools and run minimal unit and softfloat checks
>      - name: "GCC check-softfloat (user)"
>        env:
> 

Ping?

 Thomas
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Thomas Huth 5 years, 2 months ago 
On 05/09/2020 14.15, Thomas Huth wrote:
> On 05/08/2020 20.54, Thomas Huth wrote:
>> The total runtime of all Travis jobs is very long and we are testing
>> all softmmu targets in the gitlab-CI already - so we can speed up the
>> Travis testing a little bit by not testing the softmmu targets here
>> anymore.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>  that same ancient version of Ubuntu ... but do we still care about
>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>  according to our support policy, we do not care about Xenial anymore.
>>
>>  .travis.yml | 14 --------------
>>  1 file changed, 14 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 6695c0620f..18290bc51d 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -123,20 +123,6 @@ jobs:
>>          - CONFIG="--disable-system --static"
>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>  
>> -
>> -    # we split the system builds as it takes a while to build them all
>> -    - name: "GCC (main-softmmu)"
>> -      env:
>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>> -
>> -
>> -    - name: "GCC (other-softmmu)"
>> -      env:
>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>> -
>> -
>>      # Just build tools and run minimal unit and softfloat checks
>>      - name: "GCC check-softfloat (user)"
>>        env:
>>
> 
> Ping?

Ping^2 ... Alex, Philippe, any opinions on this patch?

 Thomas
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Alex Bennée 5 years, 2 months ago 
Thomas Huth <thuth@redhat.com> writes:

> On 05/09/2020 14.15, Thomas Huth wrote:
>> On 05/08/2020 20.54, Thomas Huth wrote:
>>> The total runtime of all Travis jobs is very long and we are testing
>>> all softmmu targets in the gitlab-CI already - so we can speed up the
>>> Travis testing a little bit by not testing the softmmu targets here
>>> anymore.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>>  that same ancient version of Ubuntu ... but do we still care about
>>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>>  according to our support policy, we do not care about Xenial anymore.
>>>
>>>  .travis.yml | 14 --------------
>>>  1 file changed, 14 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 6695c0620f..18290bc51d 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -123,20 +123,6 @@ jobs:
>>>          - CONFIG="--disable-system --static"
>>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>  
>>> -
>>> -    # we split the system builds as it takes a while to build them all
>>> -    - name: "GCC (main-softmmu)"
>>> -      env:
>>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>> -
>>> -
>>> -    - name: "GCC (other-softmmu)"
>>> -      env:
>>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>> -
>>> -
>>>      # Just build tools and run minimal unit and softfloat checks
>>>      - name: "GCC check-softfloat (user)"
>>>        env:
>>>
>> 
>> Ping?
>
> Ping^2 ... Alex, Philippe, any opinions on this patch?

I'm agnostic on this. Is it worth slightly reducing our coverage for ~50
minutes of runtime out of 10 hours? I guess it would be a bit greener.

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Re: [RFC PATCH] travis.yml: Drop the default softmmu builds
Posted by Thomas Huth 5 years, 2 months ago 
On 16/09/2020 15.22, Alex Bennée wrote:
> 
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 05/09/2020 14.15, Thomas Huth wrote:
>>> On 05/08/2020 20.54, Thomas Huth wrote:
>>>> The total runtime of all Travis jobs is very long and we are testing
>>>> all softmmu targets in the gitlab-CI already - so we can speed up the
>>>> Travis testing a little bit by not testing the softmmu targets here
>>>> anymore.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>>  Well, ok, we do not test all the softmmu targets on gitlab-CI with
>>>>  that same ancient version of Ubuntu ... but do we still care about
>>>>  testing all softmmut targets on Ubuntu Xenial at all? ... at least
>>>>  according to our support policy, we do not care about Xenial anymore.
>>>>
>>>>  .travis.yml | 14 --------------
>>>>  1 file changed, 14 deletions(-)
>>>>
>>>> diff --git a/.travis.yml b/.travis.yml
>>>> index 6695c0620f..18290bc51d 100644
>>>> --- a/.travis.yml
>>>> +++ b/.travis.yml
>>>> @@ -123,20 +123,6 @@ jobs:
>>>>          - CONFIG="--disable-system --static"
>>>>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>>  
>>>> -
>>>> -    # we split the system builds as it takes a while to build them all
>>>> -    - name: "GCC (main-softmmu)"
>>>> -      env:
>>>> -        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
>>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>> -
>>>> -
>>>> -    - name: "GCC (other-softmmu)"
>>>> -      env:
>>>> -       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
>>>> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>> -
>>>> -
>>>>      # Just build tools and run minimal unit and softfloat checks
>>>>      - name: "GCC check-softfloat (user)"
>>>>        env:
>>>>
>>>
>>> Ping?
>>
>> Ping^2 ... Alex, Philippe, any opinions on this patch?
> 
> I'm agnostic on this. Is it worth slightly reducing our coverage for ~50
> minutes of runtime out of 10 hours? I guess it would be a bit greener.

For the last Travis run that succeeded for me, I've got:

 Ran for 1 hr 48 min 32 sec
 Total time 7 hrs 58 min 6 sec

That means the total run time was less than 2h, it's just the total
summed up time of all jobs that is ~8h.

Since both Gitlab und Cirrus jobs finish within one hour, it would be
very convenient to have Travis also finish within one hour, so once
you've pushed your branches to gitlab and github, you could be sure to
get an answer from these three CI systems within 1 hour.

> Acked-by: Alex Bennée <alex.bennee@linaro.org>

Thanks!

  Thomas

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.