[PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI

Philippe Mathieu-Daudé posted 1 patch 3 years, 8 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200804083040.24659-1-philmd@redhat.com
docs/system/deprecated.rst | 11 +++++++++++
.travis.yml                |  7 +++++++
2 files changed, 18 insertions(+)
[PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI
Posted by Philippe Mathieu-Daudé 3 years, 8 months ago
As of QEMU 5.2 we prefer to focus our CI development on GitLab.
Mark Travis-CI as deprecated (adding a big warning).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 docs/system/deprecated.rst | 11 +++++++++++
 .travis.yml                |  7 +++++++
 2 files changed, 18 insertions(+)

diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 851dbdeb8a..c17a5b0896 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -17,6 +17,17 @@ they were first deprecated in the 2.10.0 release.
 What follows is a list of all features currently marked as
 deprecated.
 
+Build and test automation
+-------------------------
+
+``Travis-CI`` (Since 5.2)
+'''''''''''''''''''''''''
+
+``Travis-CI`` is deprecated in favor of GitLab-CI.
+
+The '.travis.yml' configuration should only be modified to remove jobs
+when equivalent exist on GitLab-CI. Adding new jobs is not allowed.
+
 System emulator command line arguments
 --------------------------------------
 
diff --git a/.travis.yml b/.travis.yml
index 6695c0620f..4ad243f511 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,3 +1,10 @@
+#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
+#
+#  As of QEMU 5.2, this file is now deprecated in favor of GitLab CI.
+#  Do not modify, except to remove jobs ported to GitLab CI.
+#
+#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
+
 # The current Travis default is a VM based 16.04 Xenial on GCE
 # Additional builds with specific requirements for a full VM need to
 # be added as additional matrix: entries later on
-- 
2.21.3

Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI
Posted by Thomas Huth 3 years, 8 months ago
On 04/08/2020 10.30, Philippe Mathieu-Daudé wrote:
> As of QEMU 5.2 we prefer to focus our CI development on GitLab.
> Mark Travis-CI as deprecated (adding a big warning).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  docs/system/deprecated.rst | 11 +++++++++++
>  .travis.yml                |  7 +++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 851dbdeb8a..c17a5b0896 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -17,6 +17,17 @@ they were first deprecated in the 2.10.0 release.
>  What follows is a list of all features currently marked as
>  deprecated.
>  
> +Build and test automation
> +-------------------------
> +
> +``Travis-CI`` (Since 5.2)
> +'''''''''''''''''''''''''
> +
> +``Travis-CI`` is deprecated in favor of GitLab-CI.
> +
> +The '.travis.yml' configuration should only be modified to remove jobs
> +when equivalent exist on GitLab-CI. Adding new jobs is not allowed.

I don't think that we need to document this for the normal users.

>  System emulator command line arguments
>  --------------------------------------
>  
> diff --git a/.travis.yml b/.travis.yml
> index 6695c0620f..4ad243f511 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -1,3 +1,10 @@
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
> +#
> +#  As of QEMU 5.2, this file is now deprecated in favor of GitLab CI.
> +#  Do not modify, except to remove jobs ported to GitLab CI.
> +#
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING

Fine for me to add this warning here (but maybe without saying 16 x
WARNING) - but I guess we'd like to keep the non-x86 build jobs here for
people who do not have access to aarch64, ppc64le and s390x runners
otherwise?

 Thomas

Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI
Posted by Daniel P. Berrangé 3 years, 8 months ago
On Tue, Aug 04, 2020 at 10:30:40AM +0200, Philippe Mathieu-Daudé wrote:
> As of QEMU 5.2 we prefer to focus our CI development on GitLab.
> Mark Travis-CI as deprecated (adding a big warning).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  docs/system/deprecated.rst | 11 +++++++++++
>  .travis.yml                |  7 +++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 851dbdeb8a..c17a5b0896 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -17,6 +17,17 @@ they were first deprecated in the 2.10.0 release.
>  What follows is a list of all features currently marked as
>  deprecated.
>  
> +Build and test automation
> +-------------------------
> +
> +``Travis-CI`` (Since 5.2)
> +'''''''''''''''''''''''''
> +
> +``Travis-CI`` is deprecated in favor of GitLab-CI.
> +
> +The '.travis.yml' configuration should only be modified to remove jobs
> +when equivalent exist on GitLab-CI. Adding new jobs is not allowed.

I don't think this is really needed. CI is not an end user feature
that is covered by deprecation policy. We simply do whatever we want
with CI at any time that suits maintainers.

>  System emulator command line arguments
>  --------------------------------------
>  
> diff --git a/.travis.yml b/.travis.yml
> index 6695c0620f..4ad243f511 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -1,3 +1,10 @@
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
> +#
> +#  As of QEMU 5.2, this file is now deprecated in favor of GitLab CI.
> +#  Do not modify, except to remove jobs ported to GitLab CI.
> +#
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING

  NOTE: GitLab provides the primary CI platform, with Cirrus CI
        as the preferred secondary. No new jobs or functionality
	should be added to Travis. The intent is to eliminate
	Travis whereever possible.

More broadly we would benefit from having a ci.rst file somewhere
in docs/ to explain our setup and strategy

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI
Posted by Alex Bennée 3 years, 8 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> As of QEMU 5.2 we prefer to focus our CI development on GitLab.
> Mark Travis-CI as deprecated (adding a big warning).

Subject doesn't match body (5.1 vs 5.2)

>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  docs/system/deprecated.rst | 11 +++++++++++
>  .travis.yml                |  7 +++++++
>  2 files changed, 18 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 851dbdeb8a..c17a5b0896 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -17,6 +17,17 @@ they were first deprecated in the 2.10.0 release.
>  What follows is a list of all features currently marked as
>  deprecated.
>  
> +Build and test automation
> +-------------------------
> +
> +``Travis-CI`` (Since 5.2)
> +'''''''''''''''''''''''''
> +
> +``Travis-CI`` is deprecated in favor of GitLab-CI.
> +
> +The '.travis.yml' configuration should only be modified to remove jobs
> +when equivalent exist on GitLab-CI. Adding new jobs is not allowed.
> +

As others have pointed out I think we need to start a new document -
docs/devel/ci.rst and start putting things in there.

>  System emulator command line arguments
>  --------------------------------------
>  
> diff --git a/.travis.yml b/.travis.yml
> index 6695c0620f..4ad243f511 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -1,3 +1,10 @@
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
> +#
> +#  As of QEMU 5.2, this file is now deprecated in favor of GitLab CI.
> +#  Do not modify, except to remove jobs ported to GitLab CI.
> +#
> +#  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING  WARNING
> +
>  # The current Travis default is a VM based 16.04 Xenial on GCE
>  # Additional builds with specific requirements for a full VM need to
>  # be added as additional matrix: entries later on


-- 
Alex Bennée