This is not a critical issue, but still annoying if you use tracing.

Maybe it is worth fixing for forks that are based on release tags,
else consider it 5.2 material.

Anyway we can still discuss if qdev_connect_clock_in() is supposed to
be callable *after* DeviceRealize.

Philippe Mathieu-Daudé (4):
  hw/arm/xilinx_zynq: Uninline cadence_uart_create()
  hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize
  hw/qdev-clock: Uninline qdev_connect_clock_in()
  hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize

 include/hw/char/cadence_uart.h | 17 -----------------
 include/hw/qdev-clock.h        |  8 +++-----
 hw/arm/xilinx_zynq.c           | 24 +++++++++++++++++-------
 hw/core/qdev-clock.c           |  6 ++++++
 4 files changed, 26 insertions(+), 29 deletions(-)

-- 
2.21.3

ping now that 5.2 is opened :)

On 8/3/20 12:56 PM, Philippe Mathieu-Daudé wrote:
> This is not a critical issue, but still annoying if you use tracing.
> 
> Maybe it is worth fixing for forks that are based on release tags,
> else consider it 5.2 material.
> 
> Anyway we can still discuss if qdev_connect_clock_in() is supposed to
> be callable *after* DeviceRealize.
> 
> Philippe Mathieu-Daudé (4):
>   hw/arm/xilinx_zynq: Uninline cadence_uart_create()
>   hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize
>   hw/qdev-clock: Uninline qdev_connect_clock_in()
>   hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize
> 
>  include/hw/char/cadence_uart.h | 17 -----------------
>  include/hw/qdev-clock.h        |  8 +++-----
>  hw/arm/xilinx_zynq.c           | 24 +++++++++++++++++-------
>  hw/core/qdev-clock.c           |  6 ++++++
>  4 files changed, 26 insertions(+), 29 deletions(-)
> 

On Mon, 3 Aug 2020 at 11:56, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> This is not a critical issue, but still annoying if you use tracing.
>
> Maybe it is worth fixing for forks that are based on release tags,
> else consider it 5.2 material.
>
> Anyway we can still discuss if qdev_connect_clock_in() is supposed to
> be callable *after* DeviceRealize.
>
> Philippe Mathieu-Daudé (4):
>   hw/arm/xilinx_zynq: Uninline cadence_uart_create()
>   hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize
>   hw/qdev-clock: Uninline qdev_connect_clock_in()
>   hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize
>


Applied to target-arm.next, thanks.

-- PMM