tests/Makefile: test-image-locking needs CONFIG_POSIX

[PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX

Thomas Huth posted 1 patch 3 years, 8 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200803065803.20836-1-thuth@redhat.com

tests/Makefile.include | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX

Posted by Thomas Huth 3 years, 8 months ago

test-image-locking.c uses the qemu_lock_fd_test() function which is
only available on Posix-like systems.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/Makefile.include | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 5ff731be2b..430119db74 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
 check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
+ifeq ($(CONFIG_POSIX),y)
 check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
+endif
 check-unit-y += tests/test-x86-cpuid$(EXESUF)
 # all code tested by test-x86-cpuid is inside topology.h
 ifeq ($(CONFIG_SOFTMMU),y)
-- 
2.18.1

Re: [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX

Posted by John Snow 3 years, 8 months ago

On 8/3/20 2:58 AM, Thomas Huth wrote:
> test-image-locking.c uses the qemu_lock_fd_test() function which is
> only available on Posix-like systems.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: John Snow <jsnow@redhat.com>

> ---
>   tests/Makefile.include | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 5ff731be2b..430119db74 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
>   check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
>   check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
>   check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
> +ifeq ($(CONFIG_POSIX),y)
>   check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
> +endif
>   check-unit-y += tests/test-x86-cpuid$(EXESUF)
>   # all code tested by test-x86-cpuid is inside topology.h
>   ifeq ($(CONFIG_SOFTMMU),y)
>