[v2] target-hppa fixes

[PATCH v2 0/4] target-hppa fixes

Posted by Helge Deller 3 years, 8 months ago

A few late fixes for target-hppa:

* Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian

* Fix the following runtime warning with artist framebuffer:
  "write outside bounds: wants 1256x1023, max size 1280x1024"

in addition the SeaBIOS-hppa firmware now includes a version check to prevent
starting when it's incompatible to the emulated qemu hardware.

Helge

----------------------------------------------------------------
Changes to v1:
* added Ack by Richard Henderson for the first patch
* revised out of bounds check based on Richards feedback

----------------------------------------------------------------

Helge Deller (3):
      hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources
      seabios-hppa: Update to SeaBIOS hppa version 1
      hw/hppa: Implement proper SeaBIOS version check

Sven Schnelle (1):
      hw/display/artist.c: fix out of bounds check

 hw/display/artist.c       |  18 ++++++------------
 hw/hppa/hppa_hardware.h   |   6 ++++++
 hw/hppa/lasi.c            |   2 --
 hw/hppa/machine.c         |  22 ++++++++++++++++++++++
 pc-bios/hppa-firmware.img | Bin 766136 -> 783144 bytes
 roms/seabios-hppa         |   2 +-
 6 files changed, 35 insertions(+), 15 deletions(-)
--
2.21.3

Helge Deller (3):
  hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources
  seabios-hppa: Update to SeaBIOS hppa version 1
  hw/hppa: Implement proper SeaBIOS version check

Sven Schnelle (1):
  hw/display/artist.c: fix out of bounds check

 hw/display/artist.c       |  24 +++++++++++-------------
 hw/hppa/hppa_hardware.h   |   6 ++++++
 hw/hppa/lasi.c            |   2 --
 hw/hppa/machine.c         |  22 ++++++++++++++++++++++
 pc-bios/hppa-firmware.img | Bin 766136 -> 783144 bytes
 roms/seabios-hppa         |   2 +-
 6 files changed, 40 insertions(+), 16 deletions(-)

--
2.21.3

Re: [PATCH v2 0/4] target-hppa fixes

Posted by Michael Tokarev 3 years, 8 months ago

01.08.2020 16:13, Helge Deller wrote:
> A few late fixes for target-hppa:
> 
> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian

It looks like you forgot the above change somehow.  And me too,
I forgot to send you a proper [PATCH] for this.  This is what
I use in Debian:

From: Michael Tokarev <mjt@tls.msk.ru>
Subject: seabios-hppa: add -fno-ipa-sra to the compiler flags
Date: Wed, 22 Jul 2020 22:15:46 +0300

This allows seabios-hppa to build with gcc-10. Or else the
compiler generates eg memset.isra.0 symbols instead of memset,
and the final link step fails due to missing memset.

Previous versions of gcc, for quite some time already, recognizes
this option but it does nothing since apparently no-ipa-sra is the
default. So there's no harm in adding it unconditionally, it seems.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

index c0d5d958..1b7757e8 100644
--- a/Makefile.parisc
+++ b/Makefile.parisc
@@ -76 +76 @@ COMMONCFLAGS := -I$(OUT) -Isrc -Ivgasrc -Os -MD -g \
-    -fno-builtin-printf
+    -fno-builtin-printf -fno-ipa-sra

This should not be required for the actual binary once it is built,
however.

Thanks,

/mjt

Re: [PATCH v2 0/4] target-hppa fixes

Posted by Helge Deller 3 years, 8 months ago

Hi Michael,

On 01.08.20 18:47, Michael Tokarev wrote:
> 01.08.2020 16:13, Helge Deller wrote:
>> A few late fixes for target-hppa:
>>
>> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>
> It looks like you forgot the above change somehow.

Actually, no, I did not forgot this patch.
It's part of the seabios-hppa repo, see here:
https://github.com/hdeller/seabios-hppa/commit/14a26ffb0d9ad1fc510da5d03215b0e36f717fce

In this qemu patch series the binary firmware-hppa.img blob I
sent was built with it.

> And me too,
> I forgot to send you a proper [PATCH] for this.  This is what
> I use in Debian:
>
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: seabios-hppa: add -fno-ipa-sra to the compiler flags
> Date: Wed, 22 Jul 2020 22:15:46 +0300
>
> This allows seabios-hppa to build with gcc-10. Or else the
> compiler generates eg memset.isra.0 symbols instead of memset,
> and the final link step fails due to missing memset.
>
> Previous versions of gcc, for quite some time already, recognizes
> this option but it does nothing since apparently no-ipa-sra is the
> default. So there's no harm in adding it unconditionally, it seems.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> index c0d5d958..1b7757e8 100644
> --- a/Makefile.parisc
> +++ b/Makefile.parisc
> @@ -76 +76 @@ COMMONCFLAGS := -I$(OUT) -Isrc -Ivgasrc -Os -MD -g \
> -    -fno-builtin-printf
> +    -fno-builtin-printf -fno-ipa-sra
>
>
> This should not be required for the actual binary once it is built,
> however.

Yep.

Thanks!
Helge

Re: [PATCH v2 0/4] target-hppa fixes

Posted by Michael Tokarev 3 years, 8 months ago

01.08.2020 20:26, Helge Deller wrote:
> Hi Michael,
> 
> On 01.08.20 18:47, Michael Tokarev wrote:
>> 01.08.2020 16:13, Helge Deller wrote:
>>> A few late fixes for target-hppa:
>>>
>>> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>>
>> It looks like you forgot the above change somehow.
> 
> Actually, no, I did not forgot this patch.
> It's part of the seabios-hppa repo, see here:
> https://github.com/hdeller/seabios-hppa/commit/14a26ffb0d9ad1fc510da5d03215b0e36f717fce

Oh. Yeah, my bad, I thought that patch should be within the 4
changes of this series, while this series is about qemu, not
the seabios-hppa sources. N/m :)

/mjt