[PATCH v2 1/4] tests/docker: Add python3-venv and netcat to the debian-amd64 container

Thomas Huth posted 4 patches 5 years, 6 months ago
Maintainers: Cleber Rosa <crosa@redhat.com>, Fam Zheng <fam@euphon.net>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, "Alex Bennée" <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Thomas Huth <thuth@redhat.com>
[PATCH v2 1/4] tests/docker: Add python3-venv and netcat to the debian-amd64 container
Posted by Thomas Huth 5 years, 6 months ago
Without python3-venv, I get the following message when trying to
run the acceptance tests within the debian container:

 The virtual environment was not created successfully because ensurepip is not
 available.  On Debian/Ubuntu systems, you need to install the python3-venv
 package using the following command.
    apt-get install python3-venv
 You may need to use sudo with that command.  After installing the python3-venv
 package, recreate your virtual environment.

Let's do it as the message suggests.

And while we're at it, also add netcat here since it is required for
some of the acceptance tests.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/docker/dockerfiles/debian-amd64.docker | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
index 8fdfd6a6b0..d2500dcff1 100644
--- a/tests/docker/dockerfiles/debian-amd64.docker
+++ b/tests/docker/dockerfiles/debian-amd64.docker
@@ -20,7 +20,9 @@ RUN apt update && \
         librdmacm-dev \
         libsasl2-dev \
         libsnappy-dev \
-        libvte-dev
+        libvte-dev \
+        netcat-openbsd \
+        python3-venv
 
 # virgl
 RUN apt update && \
-- 
2.18.1


Re: [PATCH v2 1/4] tests/docker: Add python3-venv and netcat to the debian-amd64 container
Posted by Alex Bennée 5 years, 6 months ago
Thomas Huth <thuth@redhat.com> writes:

> Without python3-venv, I get the following message when trying to
> run the acceptance tests within the debian container:
>
>  The virtual environment was not created successfully because ensurepip is not
>  available.  On Debian/Ubuntu systems, you need to install the python3-venv
>  package using the following command.
>     apt-get install python3-venv
>  You may need to use sudo with that command.  After installing the python3-venv
>  package, recreate your virtual environment.
>
> Let's do it as the message suggests.
>
> And while we're at it, also add netcat here since it is required for
> some of the acceptance tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/dockerfiles/debian-amd64.docker | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
> index 8fdfd6a6b0..d2500dcff1 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -20,7 +20,9 @@ RUN apt update && \
>          librdmacm-dev \
>          libsasl2-dev \
>          libsnappy-dev \
> -        libvte-dev
> +        libvte-dev \
> +        netcat-openbsd \
> +        python3-venv
>  
>  # virgl
>  RUN apt update && \


-- 
Alex Bennée