qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
In commit 176d2cda0dee9f4 we added the @die-id field
to the CpuInstanceProperties struct, but in the process
accidentally removed the newline between the doc-comment
lines for @core-id and @thread-id.
Put the newline back in; this fixes a misformatting in the
generated HTML QMP reference manual.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Not very important but I've suggested for-5.1 as it's a safe
docs fix. You can see the misrendered doc at
https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-CpuInstanceProperties
qapi/machine.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index f59144023ca..daede5ab149 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -825,7 +825,8 @@
# @node-id: NUMA node ID the CPU belongs to
# @socket-id: socket number within node/board the CPU belongs to
# @die-id: die number within node/board the CPU belongs to (Since 4.1)
-# @core-id: core number within die the CPU belongs to# @thread-id: thread number within core the CPU belongs to
+# @core-id: core number within die the CPU belongs to
+# @thread-id: thread number within core the CPU belongs to
#
# Note: currently there are 5 properties that could be present
# but management should be prepared to pass through other
--
2.20.1
On 7/29/20 2:10 PM, Peter Maydell wrote: > In commit 176d2cda0dee9f4 we added the @die-id field > to the CpuInstanceProperties struct, but in the process > accidentally removed the newline between the doc-comment > lines for @core-id and @thread-id. > > Put the newline back in; this fixes a misformatting in the > generated HTML QMP reference manual. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > Not very important but I've suggested for-5.1 as it's a safe > docs fix. You can see the misrendered doc at > https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-CpuInstanceProperties Reviewed-by: Eric Blake <eblake@redhat.com> > > qapi/machine.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index f59144023ca..daede5ab149 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -825,7 +825,8 @@ > # @node-id: NUMA node ID the CPU belongs to > # @socket-id: socket number within node/board the CPU belongs to > # @die-id: die number within node/board the CPU belongs to (Since 4.1) > -# @core-id: core number within die the CPU belongs to# @thread-id: thread number within core the CPU belongs to > +# @core-id: core number within die the CPU belongs to > +# @thread-id: thread number within core the CPU belongs to > # > # Note: currently there are 5 properties that could be present > # but management should be prepared to pass through other > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
On 7/29/20 9:10 PM, Peter Maydell wrote: > In commit 176d2cda0dee9f4 we added the @die-id field > to the CpuInstanceProperties struct, but in the process > accidentally removed the newline between the doc-comment > lines for @core-id and @thread-id. > > Put the newline back in; this fixes a misformatting in the > generated HTML QMP reference manual. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > Not very important but I've suggested for-5.1 as it's a safe > docs fix. You can see the misrendered doc at > https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-CpuInstanceProperties > > qapi/machine.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index f59144023ca..daede5ab149 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -825,7 +825,8 @@ > # @node-id: NUMA node ID the CPU belongs to > # @socket-id: socket number within node/board the CPU belongs to > # @die-id: die number within node/board the CPU belongs to (Since 4.1) > -# @core-id: core number within die the CPU belongs to# @thread-id: thread number within core the CPU belongs to > +# @core-id: core number within die the CPU belongs to > +# @thread-id: thread number within core the CPU belongs to > # > # Note: currently there are 5 properties that could be present > # but management should be prepared to pass through other > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Peter Maydell <peter.maydell@linaro.org> writes: > In commit 176d2cda0dee9f4 we added the @die-id field > to the CpuInstanceProperties struct, but in the process > accidentally removed the newline between the doc-comment > lines for @core-id and @thread-id. > > Put the newline back in; this fixes a misformatting in the > generated HTML QMP reference manual. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > Not very important but I've suggested for-5.1 as it's a safe > docs fix. You can see the misrendered doc at > https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#index-CpuInstanceProperties Makes sense. Queued, thanks!
© 2016 - 2024 Red Hat, Inc.