[PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror

Thomas Huth posted 4 patches 5 years, 6 months ago
Maintainers: Li-Wen Hsu <lwhsu@freebsd.org>, Ed Maste <emaste@freebsd.org>
[PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror
Posted by Thomas Huth 5 years, 6 months ago
Compiler warnings currently go unnoticed in our FreeBSD builds, since
-Werror is only enabled for Linux and MinGW builds by default. So let's
enable them here now, too.

Reviewed-by: Ed Maste <emaste@freebsd.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .cirrus.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index f287d23c5b..b50da72eec 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -12,7 +12,7 @@ freebsd_12_task:
   script:
     - mkdir build
     - cd build
-    - ../configure || { cat config.log; exit 1; }
+    - ../configure --enable-werror || { cat config.log; exit 1; }
     - gmake -j8
     - gmake V=1 check
 
-- 
2.18.1


Re: [PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror
Posted by Daniel P. Berrangé 5 years, 6 months ago
On Tue, Jul 28, 2020 at 09:44:03AM +0200, Thomas Huth wrote:
> Compiler warnings currently go unnoticed in our FreeBSD builds, since
> -Werror is only enabled for Linux and MinGW builds by default. So let's
> enable them here now, too.
> 
> Reviewed-by: Ed Maste <emaste@freebsd.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .cirrus.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|