virtio-pci: fix wrong index in virtio_pci_queue_enabled

[PATCH] virtio-pci: fix wrong index in virtio_pci_queue_enabled

Yuri Benditovich posted 1 patch 3 years, 9 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200727143807.19230-1-yuri.benditovich@daynix.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>

hw/virtio/virtio-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] virtio-pci: fix wrong index in virtio_pci_queue_enabled

Posted by Yuri Benditovich 3 years, 9 months ago

https://bugzilla.redhat.com/show_bug.cgi?id=1702608

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 hw/virtio/virtio-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ada1101d07..2b1f9cc67b 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1113,7 +1113,7 @@ static bool virtio_pci_queue_enabled(DeviceState *d, int n)
     VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
 
     if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
-        return proxy->vqs[vdev->queue_sel].enabled;
+        return proxy->vqs[n].enabled;
     }
 
     return virtio_queue_enabled(vdev, n);
-- 
2.17.1

Re: [PATCH] virtio-pci: fix wrong index in virtio_pci_queue_enabled

Posted by Jason Wang 3 years, 9 months ago

On 2020/7/27 下午10:38, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1702608
>
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>


Queued for rc2.

Thanks


> ---
>   hw/virtio/virtio-pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index ada1101d07..2b1f9cc67b 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1113,7 +1113,7 @@ static bool virtio_pci_queue_enabled(DeviceState *d, int n)
>       VirtIODevice *vdev = virtio_bus_get_device(&proxy->bus);
>   
>       if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
> -        return proxy->vqs[vdev->queue_sel].enabled;
> +        return proxy->vqs[n].enabled;
>       }
>   
>       return virtio_queue_enabled(vdev, n);