1. Patchew
  2. QEMU
  3. View series

[PATCH] qemu-options.hx: Fix typo for netdev documentation

Tianjia Zhang posted 1 patch 3 years, 9 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200727045925.29375-1-tianjia.zhang@linux.alibaba.com
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Tianjia Zhang 3 years, 9 months ago 
This patch fixes the netdev document description typo in qemu-option.hx.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 708583b4ce..92556ed96d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2684,7 +2684,7 @@ SRST
     disable script execution.
 
     If running QEMU as an unprivileged user, use the network helper
-    helper to configure the TAP interface and attach it to the bridge.
+    to configure the TAP interface and attach it to the bridge.
     The default network helper executable is
     ``/path/to/qemu-bridge-helper`` and the default bridge device is
     ``br0``.
-- 
2.17.1
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Thomas Huth 3 years, 9 months ago 
On 27/07/2020 06.59, Tianjia Zhang wrote:
> This patch fixes the netdev document description typo in qemu-option.hx.
> 
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 708583b4ce..92556ed96d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2684,7 +2684,7 @@ SRST
>      disable script execution.
>  
>      If running QEMU as an unprivileged user, use the network helper
> -    helper to configure the TAP interface and attach it to the bridge.
> +    to configure the TAP interface and attach it to the bridge.
>      The default network helper executable is
>      ``/path/to/qemu-bridge-helper`` and the default bridge device is
>      ``br0``.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Li Qiang 3 years, 9 months ago 
Tianjia Zhang <tianjia.zhang@linux.alibaba.com> 于2020年7月27日周一 下午1:00写道：
>
> This patch fixes the netdev document description typo in qemu-option.hx.
>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 708583b4ce..92556ed96d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2684,7 +2684,7 @@ SRST
>      disable script execution.
>
>      If running QEMU as an unprivileged user, use the network helper
> -    helper to configure the TAP interface and attach it to the bridge.
> +    to configure the TAP interface and attach it to the bridge.
>      The default network helper executable is
>      ``/path/to/qemu-bridge-helper`` and the default bridge device is
>      ``br0``.
> --
> 2.17.1
>
>
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Michael S. Tsirkin 3 years, 9 months ago 
On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote:
> This patch fixes the netdev document description typo in qemu-option.hx.
> 
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Trivial tree? Jason's ?

> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 708583b4ce..92556ed96d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2684,7 +2684,7 @@ SRST
>      disable script execution.
>  
>      If running QEMU as an unprivileged user, use the network helper
> -    helper to configure the TAP interface and attach it to the bridge.
> +    to configure the TAP interface and attach it to the bridge.
>      The default network helper executable is
>      ``/path/to/qemu-bridge-helper`` and the default bridge device is
>      ``br0``.
> -- 
> 2.17.1
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Tianjia Zhang 3 years, 9 months ago 

On 2020/7/27 17:44, Michael S. Tsirkin wrote:
> On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote:
>> This patch fixes the netdev document description typo in qemu-option.hx.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Trivial tree? Jason's ?
> 

It's for mainline tree.

Thanks
>> ---
>>   qemu-options.hx | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 708583b4ce..92556ed96d 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2684,7 +2684,7 @@ SRST
>>       disable script execution.
>>   
>>       If running QEMU as an unprivileged user, use the network helper
>> -    helper to configure the TAP interface and attach it to the bridge.
>> +    to configure the TAP interface and attach it to the bridge.
>>       The default network helper executable is
>>       ``/path/to/qemu-bridge-helper`` and the default bridge device is
>>       ``br0``.
>> -- 
>> 2.17.1
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Tianjia Zhang 3 years, 8 months ago 
Hi,

Other opinions needed?


Thanks,

Tianjia

On 7/27/20 5:44 PM, Michael S. Tsirkin wrote:
> On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote:
>> This patch fixes the netdev document description typo in qemu-option.hx.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Trivial tree? Jason's ?
>
>> ---
>>   qemu-options.hx | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 708583b4ce..92556ed96d 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2684,7 +2684,7 @@ SRST
>>       disable script execution.
>>   
>>       If running QEMU as an unprivileged user, use the network helper
>> -    helper to configure the TAP interface and attach it to the bridge.
>> +    to configure the TAP interface and attach it to the bridge.
>>       The default network helper executable is
>>       ``/path/to/qemu-bridge-helper`` and the default bridge device is
>>       ``br0``.
>> -- 
>> 2.17.1
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Peter Maydell 3 years, 8 months ago 
On Thu, 27 Aug 2020 at 14:00, Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
> Other opinions needed?

No, the patch just got lost by accident; sorry.

Jason, could you take this via your net tree, please?

thanks
-- PMM

>
> On 7/27/20 5:44 PM, Michael S. Tsirkin wrote:
> > On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote:
> >> This patch fixes the netdev document description typo in qemu-option.hx.
> >>
> >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Trivial tree? Jason's ?
> >
> >> ---
> >>   qemu-options.hx | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/qemu-options.hx b/qemu-options.hx
> >> index 708583b4ce..92556ed96d 100644
> >> --- a/qemu-options.hx
> >> +++ b/qemu-options.hx
> >> @@ -2684,7 +2684,7 @@ SRST
> >>       disable script execution.
> >>
> >>       If running QEMU as an unprivileged user, use the network helper
> >> -    helper to configure the TAP interface and attach it to the bridge.
> >> +    to configure the TAP interface and attach it to the bridge.
> >>       The default network helper executable is
> >>       ``/path/to/qemu-bridge-helper`` and the default bridge device is
> >>       ``br0``.
> >> --
> >> 2.17.1
Re: [PATCH] qemu-options.hx: Fix typo for netdev documentation
Posted by Laurent Vivier 3 years, 8 months ago 
Le 27/08/2020 à 15:03, Peter Maydell a écrit :
> On Thu, 27 Aug 2020 at 14:00, Tianjia Zhang
> <tianjia.zhang@linux.alibaba.com> wrote:
>> Other opinions needed?
> 
> No, the patch just got lost by accident; sorry.
> 
> Jason, could you take this via your net tree, please?
> 
> thanks
> -- PMM
> 
>>
>> On 7/27/20 5:44 PM, Michael S. Tsirkin wrote:
>>> On Mon, Jul 27, 2020 at 12:59:25PM +0800, Tianjia Zhang wrote:
>>>> This patch fixes the netdev document description typo in qemu-option.hx.
>>>>
>>>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>>> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>>>
>>> Trivial tree? Jason's ?

I'm taking it via the trivial tree.

Thanks,
Laurent

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.