[v2] Allow guest-get-fsinfo also for non-PCI devices

[PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices

Thomas Huth posted 4 patches 5 years, 3 months ago

Diff against v1
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200722044028.4059-1-thuth@redhat.com

Maintainers: Michael Roth <mdroth@linux.vnet.ibm.com>

qga/commands-posix.c | 157 ++++++++++++++++++++++++++++++-------------
qga/qapi-schema.json |   2 +-
2 files changed, 110 insertions(+), 49 deletions(-)

Expand all Fold all

[PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices

Posted by Thomas Huth 5 years, 3 months ago

The information that can be retrieved via UDEV is also usable for non-PCI
devices. So let's allow build_guest_fsinfo_for_real_device() on non-PCI
devices, too. This is required to fix the bug that CCW devices show up
without "Target" when running libvirt's "virsh domfsinfo" command (see
https://bugzilla.redhat.com/show_bug.cgi?id=1755075 for details).

v2:
 - Use g_new0 instead of g_malloc0 (as suggested by Daniel)
 - Init fields to -1 explicitely, not via memset (Daniel)
 - Add the fourth patch to also fill in virtio information on s390x

Thomas Huth (4):
  qga/qapi-schema: Document -1 for invalid PCI address fields
  qga/commands-posix: Rework build_guest_fsinfo_for_real_device()
    function
  qga/commands-posix: Move the udev code from the pci to the generic
    function
  qga/commands-posix: Support fsinfo for non-PCI virtio devices, too

 qga/commands-posix.c | 157 ++++++++++++++++++++++++++++++-------------
 qga/qapi-schema.json |   2 +-
 2 files changed, 110 insertions(+), 49 deletions(-)

-- 
2.18.1

Re: [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices

Posted by Michael Roth 5 years, 3 months ago

Quoting Thomas Huth (2020-07-21 23:40:24)
> The information that can be retrieved via UDEV is also usable for non-PCI
> devices. So let's allow build_guest_fsinfo_for_real_device() on non-PCI
> devices, too. This is required to fix the bug that CCW devices show up
> without "Target" when running libvirt's "virsh domfsinfo" command (see
> https://bugzilla.redhat.com/show_bug.cgi?id=1755075 for details).
> 
> v2:
>  - Use g_new0 instead of g_malloc0 (as suggested by Daniel)
>  - Init fields to -1 explicitely, not via memset (Daniel)
>  - Add the fourth patch to also fill in virtio information on s390x

Thanks, patches 2-4 applied to qga-staging tree for 5.2:
  https://github.com/mdroth/qemu/commits/qga-staging

I've sent a pull request for 5.1 with patch 1/4

> 
> Thomas Huth (4):
>   qga/qapi-schema: Document -1 for invalid PCI address fields
>   qga/commands-posix: Rework build_guest_fsinfo_for_real_device()
>     function
>   qga/commands-posix: Move the udev code from the pci to the generic
>     function
>   qga/commands-posix: Support fsinfo for non-PCI virtio devices, too
> 
>  qga/commands-posix.c | 157 ++++++++++++++++++++++++++++++-------------
>  qga/qapi-schema.json |   2 +-
>  2 files changed, 110 insertions(+), 49 deletions(-)
> 
> -- 
> 2.18.1
>