[v2] Generalize start-powered-off property from ARM

[PATCH v2 0/9] Generalize start-powered-off property from ARM

Thiago Jung Bauermann posted 9 patches 5 years, 3 months ago

Diff against v3 v4 v5 v6 v7
Download series mbox

Test FreeBSD failed

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200722035016.469075-1-bauerman@linux.ibm.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Cornelia Huck <cohuck@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Richard Henderson <rth@twiddle.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Thomas Huth <thuth@redhat.com>, David Hildenbrand <david@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

There is a newer version of this series

exec.c                  |  1 +
hw/core/cpu.c           |  2 +-
hw/mips/cps.c           |  6 +++---
hw/ppc/e500.c           | 10 +++++++---
hw/ppc/spapr_cpu_core.c | 12 +++++++-----
hw/sparc/sun4m.c        | 23 +++++------------------
include/hw/core/cpu.h   |  4 ++++
target/arm/cpu.c        |  4 +---
target/arm/cpu.h        |  3 ---
target/arm/kvm32.c      |  2 +-
target/arm/kvm64.c      |  2 +-
target/s390x/cpu.c      |  3 ++-
12 files changed, 33 insertions(+), 39 deletions(-)

Expand all Fold all

[PATCH v2 0/9] Generalize start-powered-off property from ARM

Posted by Thiago Jung Bauermann 5 years, 3 months ago

The ARM code has a start-powered-off property in ARMCPU, which is a
subclass of CPUState. This property causes arm_cpu_reset() to set
CPUState::halted to 1, signalling that the CPU should start in a halted
state. Other architectures also have code which aim to achieve the same
effect, but without using a property.

The ppc/spapr version has a bug where QEMU does a KVM_RUN on the vcpu
before cs->halted is set to 1, causing the vcpu to run while it's still in
an unitialized state (more details in patch 3).

Peter Maydell mentioned the ARM start-powered-off property and
Eduardo Habkost suggested making it generic, so this patch series does
that, for all cases which I was able to find via grep in the code.

The only problem is that I was only able to test these changes on a ppc64le
pseries KVM guest, so except for patches 2 and 3, all others are only
build-tested. Also, my grasp of QOM lifecycle is basically non-existant so
please be aware of that when reviewing this series.

The last 3 patches I think are good cleanups but I'm even less confident in
their correctness compared to the other patches, so I marked them as RFC.

Applies cleanly on yesterday's master.

Thiago Jung Bauermann (9):
  target/arm: Move start-powered-off property to generic CPUState
  target/arm: Move setting of CPU halted state to generic code
  ppc/spapr: Use start-powered-off CPUState property
  ppc/e500: Use start-powered-off CPUState property
  mips/cps: Use start-powered-off CPUState property
  sparc/sun4m: Use start-powered-off CPUState property
  sparc/sun4m: Don't set CPUState::halted in cpu_devinit()
  sparc/sun4m: Use one cpu_reset() function for main and secondary CPUs
  target/s390x: Use start-powered-off CPUState property

 exec.c                  |  1 +
 hw/core/cpu.c           |  2 +-
 hw/mips/cps.c           |  6 +++---
 hw/ppc/e500.c           | 10 +++++++---
 hw/ppc/spapr_cpu_core.c | 12 +++++++-----
 hw/sparc/sun4m.c        | 23 +++++------------------
 include/hw/core/cpu.h   |  4 ++++
 target/arm/cpu.c        |  4 +---
 target/arm/cpu.h        |  3 ---
 target/arm/kvm32.c      |  2 +-
 target/arm/kvm64.c      |  2 +-
 target/s390x/cpu.c      |  3 ++-
 12 files changed, 33 insertions(+), 39 deletions(-)