non-blocking connect

[PATCH for-5.1? 0/4] non-blocking connect

Vladimir Sementsov-Ogievskiy posted 4 patches 5 years, 3 months ago

Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200720180715.10521-1-vsementsov@virtuozzo.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Max Reitz <mreitz@redhat.com>

include/io/channel-socket.h | 14 +++++++
include/qemu/sockets.h      |  6 +++
block/nbd.c                 | 11 +++---
io/channel-socket.c         | 74 ++++++++++++++++++++++++++++++++++++
util/qemu-sockets.c         | 76 ++++++++++++++++++++++++++-----------
5 files changed, 153 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH for-5.1? 0/4] non-blocking connect

Posted by Vladimir Sementsov-Ogievskiy 5 years, 3 months ago

Hi! This fixes real problem (see 04). On the other hand it may be too
much for 5.1, and it's not a degradation. So, up to you.

It's based on "[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks", or
in other words
Based-on: <20200720090024.18186-1-vsementsov@virtuozzo.com>

Vladimir Sementsov-Ogievskiy (4):
  qemu-sockets: refactor inet_connect_addr
  qemu-sockets: implement non-blocking connect interface
  io/channel-socket: implement non-blocking connect
  block/nbd: use non-blocking connect: fix vm hang on connect()

 include/io/channel-socket.h | 14 +++++++
 include/qemu/sockets.h      |  6 +++
 block/nbd.c                 | 11 +++---
 io/channel-socket.c         | 74 ++++++++++++++++++++++++++++++++++++
 util/qemu-sockets.c         | 76 ++++++++++++++++++++++++++-----------
 5 files changed, 153 insertions(+), 28 deletions(-)

-- 
2.21.0

Re: [PATCH for-5.1? 0/4] non-blocking connect

Posted by Eric Blake 5 years, 3 months ago

On 7/20/20 1:07 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi! This fixes real problem (see 04). On the other hand it may be too
> much for 5.1, and it's not a degradation. So, up to you.

Given the concerns raised on 3, I think I'll wait for v2 of the series, 
and defer it to 5.2.

> 
> It's based on "[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks", or
> in other words
> Based-on: <20200720090024.18186-1-vsementsov@virtuozzo.com>
> 
> Vladimir Sementsov-Ogievskiy (4):
>    qemu-sockets: refactor inet_connect_addr
>    qemu-sockets: implement non-blocking connect interface
>    io/channel-socket: implement non-blocking connect
>    block/nbd: use non-blocking connect: fix vm hang on connect()
> 
>   include/io/channel-socket.h | 14 +++++++
>   include/qemu/sockets.h      |  6 +++
>   block/nbd.c                 | 11 +++---
>   io/channel-socket.c         | 74 ++++++++++++++++++++++++++++++++++++
>   util/qemu-sockets.c         | 76 ++++++++++++++++++++++++++-----------
>   5 files changed, 153 insertions(+), 28 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org