qdev: Document qdev_prop_set_drive_err() return value

[PATCH] qdev: Document qdev_prop_set_drive_err() return value

Posted by Philippe Mathieu-Daudé 5 years, 2 months ago

Since commit 73ac1aac39 qdev_prop_set_drive_err() returns
a boolean value. Document it.

Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void"
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 include/hw/qdev-properties.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 587e5b7d31..3a64d5ab9a 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
 
 /*
  * Set properties between creation and realization.
+ *
+ * Returns: %true on success, %false on error.
  */
 bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
                              BlockBackend *value, Error **errp);
-- 
2.21.3

Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20200720121659.31886-1-f4bug@amsat.org/



Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20200720121659.31886-1-f4bug@amsat.org/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value

Posted by Markus Armbruster 5 years, 2 months ago

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Since commit 73ac1aac39 qdev_prop_set_drive_err() returns
> a boolean value. Document it.
>
> Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void"
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  include/hw/qdev-properties.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 587e5b7d31..3a64d5ab9a 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
>  
>  /*
>   * Set properties between creation and realization.
> + *
> + * Returns: %true on success, %false on error.
>   */
>  bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
>                               BlockBackend *value, Error **errp);

Reviewed-by: Markus Armbruster <armbru@redhat.com>