[PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup

Klaus Jensen posted 16 patches 5 years, 3 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200720113748.322965-1-its@irrelevant.dk
Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Keith Busch <kbusch@kernel.org>, Fam Zheng <fam@euphon.net>
There is a newer version of this series
block/nvme.c          |   4 +-
hw/block/nvme.c       | 498 +++++++++++++++++++++++++++---------------
hw/block/nvme.h       |   4 +-
hw/block/trace-events |   4 +
include/block/nvme.h  |   4 +-
5 files changed, 331 insertions(+), 183 deletions(-)
[PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup
Posted by Klaus Jensen 5 years, 3 months ago
From: Klaus Jensen <k.jensen@samsung.com>

This series consists of patches that refactors dma read/write and adds a
number of address mapping helper functions.

Based-on: <20200706061303.246057-1-its@irrelevant.dk>

Klaus Jensen (16):
  hw/block/nvme: memset preallocated requests structures
  hw/block/nvme: add mapping helpers
  hw/block/nvme: replace dma_acct with blk_acct equivalent
  hw/block/nvme: remove redundant has_sg member
  hw/block/nvme: refactor dma read/write
  hw/block/nvme: pass request along for tracing
  hw/block/nvme: add request mapping helper
  hw/block/nvme: verify validity of prp lists in the cmb
  hw/block/nvme: refactor request bounds checking
  hw/block/nvme: add check for mdts
  hw/block/nvme: be consistent about zeros vs zeroes
  hw/block/nvme: refactor NvmeRequest clearing
  hw/block/nvme: add a namespace reference in NvmeRequest
  hw/block/nvme: consolidate qsg/iov clearing
  hw/block/nvme: remove NvmeCmd parameter
  hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp

 block/nvme.c          |   4 +-
 hw/block/nvme.c       | 498 +++++++++++++++++++++++++++---------------
 hw/block/nvme.h       |   4 +-
 hw/block/trace-events |   4 +
 include/block/nvme.h  |   4 +-
 5 files changed, 331 insertions(+), 183 deletions(-)

-- 
2.27.0


Re: [PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup
Posted by Klaus Jensen 5 years, 3 months ago
On Jul 20 13:37, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This series consists of patches that refactors dma read/write and adds a
> number of address mapping helper functions.
> 
> Based-on: <20200706061303.246057-1-its@irrelevant.dk>
> 
> Klaus Jensen (16):
>   hw/block/nvme: memset preallocated requests structures
>   hw/block/nvme: add mapping helpers
>   hw/block/nvme: replace dma_acct with blk_acct equivalent
>   hw/block/nvme: remove redundant has_sg member
>   hw/block/nvme: refactor dma read/write
>   hw/block/nvme: pass request along for tracing
>   hw/block/nvme: add request mapping helper
>   hw/block/nvme: verify validity of prp lists in the cmb
>   hw/block/nvme: refactor request bounds checking
>   hw/block/nvme: add check for mdts
>   hw/block/nvme: be consistent about zeros vs zeroes
>   hw/block/nvme: refactor NvmeRequest clearing
>   hw/block/nvme: add a namespace reference in NvmeRequest
>   hw/block/nvme: consolidate qsg/iov clearing
>   hw/block/nvme: remove NvmeCmd parameter
>   hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp
> 
>  block/nvme.c          |   4 +-
>  hw/block/nvme.c       | 498 +++++++++++++++++++++++++++---------------
>  hw/block/nvme.h       |   4 +-
>  hw/block/trace-events |   4 +
>  include/block/nvme.h  |   4 +-
>  5 files changed, 331 insertions(+), 183 deletions(-)
> 
> -- 
> 2.27.0
> 

Gentle ping on this.

Requesting reviews on

  [02/16]: hw/block/nvme: add mapping helpers
  [11/16]: hw/block/nvme: be consistent about zeros vs zeroes
  [12/16]: hw/block/nvme: refactor NvmeRequest clearing
  [13/16]: hw/block/nvme: add a namespace reference in NvmeRequest
  [14/16]: hw/block/nvme: consolidate qsg/iov clearing
  [15/16]: hw/block/nvme: remove NvmeCmd parameter

I think only 02/16 has some meat on it.


Thanks,
Klaus

Re: [PATCH 00/16] hw/block/nvme: dma handling and address mapping cleanup
Posted by Keith Busch 5 years, 3 months ago
On Mon, Jul 27, 2020 at 11:42:46AM +0200, Klaus Jensen wrote:
> On Jul 20 13:37, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > This series consists of patches that refactors dma read/write and adds a
> > number of address mapping helper functions.
> > 
> > Based-on: <20200706061303.246057-1-its@irrelevant.dk>
> > 
> > Klaus Jensen (16):
> >   hw/block/nvme: memset preallocated requests structures
> >   hw/block/nvme: add mapping helpers
> >   hw/block/nvme: replace dma_acct with blk_acct equivalent
> >   hw/block/nvme: remove redundant has_sg member
> >   hw/block/nvme: refactor dma read/write
> >   hw/block/nvme: pass request along for tracing
> >   hw/block/nvme: add request mapping helper
> >   hw/block/nvme: verify validity of prp lists in the cmb
> >   hw/block/nvme: refactor request bounds checking
> >   hw/block/nvme: add check for mdts
> >   hw/block/nvme: be consistent about zeros vs zeroes
> >   hw/block/nvme: refactor NvmeRequest clearing
> >   hw/block/nvme: add a namespace reference in NvmeRequest
> >   hw/block/nvme: consolidate qsg/iov clearing
> >   hw/block/nvme: remove NvmeCmd parameter
> >   hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp
> > 
> >  block/nvme.c          |   4 +-
> >  hw/block/nvme.c       | 498 +++++++++++++++++++++++++++---------------
> >  hw/block/nvme.h       |   4 +-
> >  hw/block/trace-events |   4 +
> >  include/block/nvme.h  |   4 +-
> >  5 files changed, 331 insertions(+), 183 deletions(-)
> > 
> > -- 
> > 2.27.0
> > 
> 
> Gentle ping on this.

I'll have free time to get back to this probably end of the week,
possibly early next week.