[v1] Fix nbd reconnect dead-locks

[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks

Vladimir Sementsov-Ogievskiy posted 3 patches 5 years, 3 months ago

Diff against v2
Download series mbox

Test checkpatch failed

Test docker-mingw@fedora failed

Test FreeBSD passed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200720090024.18186-1-vsementsov@virtuozzo.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

block/nbd.c | 36 +++++++++++++++++++++++++++---------
1 file changed, 27 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks

Posted by Vladimir Sementsov-Ogievskiy 5 years, 3 months ago

Hi all!

I've found some dead-locks, which can be easily triggered on master
branch with default nbd configuration (reconnect-delay is 0),
here are fixes.

01-02 fix real dead-locks 
03 - hm. I'm not sure that the problem is reachable on master, I've
faced it in my development branch where I move initial connect into
coroutine and introduce non-blocking connect. So consider it as an
intuitive fix. It just makes code a bit better.

Vladimir Sementsov-Ogievskiy (3):
  block/nbd: allow drain during reconnect attempt
  block/nbd: on shutdown terminate connection attempt
  block/nbd: nbd_co_reconnect_loop(): don't sleep if drained

 block/nbd.c | 36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)

-- 
2.21.0