[v2] Add dtrace support on macOS

[PATCH v2 0/4] Add dtrace support on macOS

Roman Bolshakov posted 4 patches 3 years, 9 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Test docker-mingw@fedora failed

Test FreeBSD passed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200717093517.73397-1-r.bolshakov@yadro.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>

Makefile.objs                 |  2 ++
net/colo-compare.c            | 42 ++++++++++++++++++-----------------
net/filter-rewriter.c         | 10 +++++++--
net/trace-events              |  2 --
scripts/tracetool/format/d.py | 15 ++++++++++++-
scripts/tracetool/vcpu.py     |  2 +-
6 files changed, 47 insertions(+), 26 deletions(-)

Expand all Fold all

[PATCH v2 0/4] Add dtrace support on macOS

Posted by Roman Bolshakov 3 years, 9 months ago

Hi,

This is a small series that enables dtrace tracing backend on macOS.
Whether or not it should go to 5.1 is up to discretion of tracing
maintainers.

Thanks,
Roman

Changes since v1:
 - Fixed a typo ANSI C to C99, wrt to _Bool in the first patch.
 - Prevented a few [-Wpointer-sign] warnings by converting int8_t * to
   signed char * in static probe definitions.
 - Moved COLO packet dump under #ifdef DEBUG_COLO_PACKETS (Daniel).
 - Separated tracepoints in net/filter-rewriter.c to use matching
   is-enabled probe (Daniel).

Roman Bolshakov (4):
  scripts/tracetool: Fix dtrace generation for macOS
  scripts/tracetool: Use void pointer for vcpu
  build: Don't make object files for dtrace on macOS
  net/colo: Match is-enabled probe to tracepoint

 Makefile.objs                 |  2 ++
 net/colo-compare.c            | 42 ++++++++++++++++++-----------------
 net/filter-rewriter.c         | 10 +++++++--
 net/trace-events              |  2 --
 scripts/tracetool/format/d.py | 15 ++++++++++++-
 scripts/tracetool/vcpu.py     |  2 +-
 6 files changed, 47 insertions(+), 26 deletions(-)

-- 
2.26.1

Re: [PATCH v2 0/4] Add dtrace support on macOS

Posted by Stefan Hajnoczi 3 years, 9 months ago

On Fri, Jul 17, 2020 at 12:35:13PM +0300, Roman Bolshakov wrote:
> Hi,
> 
> This is a small series that enables dtrace tracing backend on macOS.
> Whether or not it should go to 5.1 is up to discretion of tracing
> maintainers.

Thanks for the patches. I would like to apply them for QEMU 5.2.

I have reviewed patches 1-3 and will wait for discussion to finish on
patch 4.

Stefan

Re: [PATCH v2 0/4] Add dtrace support on macOS

Posted by Stefan Hajnoczi 3 years, 9 months ago

On Fri, Jul 17, 2020 at 12:35:13PM +0300, Roman Bolshakov wrote:
> Hi,
> 
> This is a small series that enables dtrace tracing backend on macOS.
> Whether or not it should go to 5.1 is up to discretion of tracing
> maintainers.
> 
> Thanks,
> Roman
> 
> Changes since v1:
>  - Fixed a typo ANSI C to C99, wrt to _Bool in the first patch.
>  - Prevented a few [-Wpointer-sign] warnings by converting int8_t * to
>    signed char * in static probe definitions.
>  - Moved COLO packet dump under #ifdef DEBUG_COLO_PACKETS (Daniel).
>  - Separated tracepoints in net/filter-rewriter.c to use matching
>    is-enabled probe (Daniel).
> 
> Roman Bolshakov (4):
>   scripts/tracetool: Fix dtrace generation for macOS
>   scripts/tracetool: Use void pointer for vcpu
>   build: Don't make object files for dtrace on macOS
>   net/colo: Match is-enabled probe to tracepoint
> 
>  Makefile.objs                 |  2 ++
>  net/colo-compare.c            | 42 ++++++++++++++++++-----------------
>  net/filter-rewriter.c         | 10 +++++++--
>  net/trace-events              |  2 --
>  scripts/tracetool/format/d.py | 15 ++++++++++++-
>  scripts/tracetool/vcpu.py     |  2 +-
>  6 files changed, 47 insertions(+), 26 deletions(-)
> 
> -- 
> 2.26.1
> 

Thanks, applied to my tracing-next tree:
https://github.com/stefanha/qemu/commits/tracing-next

Stefan