usb: only build hcd-dwc2 host controller for RASPI target

[PATCH] usb: only build hcd-dwc2 host controller for RASPI target

Paul Zimmerman posted 1 patch 3 years, 9 months ago

Download mbox

Test checkpatch passed

Test docker-mingw@fedora passed

Test FreeBSD passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200717010548.9902-1-pauldzim@gmail.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

hw/arm/Kconfig | 1 +
hw/usb/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] usb: only build hcd-dwc2 host controller for RASPI target

Posted by Paul Zimmerman 3 years, 9 months ago

The hcd-dwc2 host controller is currently built for all targets.
Since for now hcd-dwc2 is only implemented on RASPI, restrict its
build to that target only.

Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
---

Hi Gerd,

Do we want to apply this before the 5.1.0 release? It seems a waste
to build this code for every target when it's only used on one.
Sorry I didn't realize this earlier.

Thanks,
Paul

 hw/arm/Kconfig | 1 +
 hw/usb/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 4a224a6351..bc3a423940 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -315,6 +315,7 @@ config RASPI
     select FRAMEBUFFER
     select PL011 # UART
     select SDHCI
+    select USB_DWC2
 
 config STM32F205_SOC
     bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index d4d8c37c28..5e63dc75f8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -48,7 +48,6 @@ config USB_MUSB
 
 config USB_DWC2
     bool
-    default y
     select USB
 
 config TUSB6010
-- 
2.17.1

Re: [PATCH] usb: only build hcd-dwc2 host controller for RASPI target

Posted by Philippe Mathieu-Daudé 3 years, 9 months ago

On 7/17/20 3:05 AM, Paul Zimmerman wrote:
> The hcd-dwc2 host controller is currently built for all targets.
> Since for now hcd-dwc2 is only implemented on RASPI, restrict its
> build to that target only.
> 
> Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
> ---
> 
> Hi Gerd,
> 
> Do we want to apply this before the 5.1.0 release? It seems a waste
> to build this code for every target when it's only used on one.
> Sorry I didn't realize this earlier.

Not a big deal ;)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> 
> Thanks,
> Paul
> 
>  hw/arm/Kconfig | 1 +
>  hw/usb/Kconfig | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 4a224a6351..bc3a423940 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -315,6 +315,7 @@ config RASPI
>      select FRAMEBUFFER
>      select PL011 # UART
>      select SDHCI
> +    select USB_DWC2
>  
>  config STM32F205_SOC
>      bool
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index d4d8c37c28..5e63dc75f8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -48,7 +48,6 @@ config USB_MUSB
>  
>  config USB_DWC2
>      bool
> -    default y
>      select USB
>  
>  config TUSB6010
>