[PATCH] docs/s390x: fix vfio-ccw type

Cornelia Huck posted 1 patch 3 years, 9 months ago
Test checkpatch passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200716145031.771476-1-cohuck@redhat.com
Maintainers: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>
docs/system/s390x/vfio-ccw.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] docs/s390x: fix vfio-ccw type
Posted by Cornelia Huck 3 years, 9 months ago
Fix the type name in the mdevctl example.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---

I always seem to get this one wrong, and mdevctl does not complain until
it wants to start the device...

---
 docs/system/s390x/vfio-ccw.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/system/s390x/vfio-ccw.rst b/docs/system/s390x/vfio-ccw.rst
index 8f65442c0f56..41e0bad5b489 100644
--- a/docs/system/s390x/vfio-ccw.rst
+++ b/docs/system/s390x/vfio-ccw.rst
@@ -29,7 +29,7 @@ automatically, use
 
    [root@host ~]# driverctl -b css set-override 0.0.0313 vfio_ccw
    [root@host ~]# mdevctl define -u 7e270a25-e163-4922-af60-757fc8ed48c6 \
-                  -p 0.0.0313 -t vfio-ccw_io -a
+                  -p 0.0.0313 -t vfio_ccw-io -a
 
 If using ``mdevctl`` is not possible or wanted, follow the manual procedure
 below.
-- 
2.25.4


Re: [PATCH] docs/s390x: fix vfio-ccw type
Posted by Eric Farman 3 years, 9 months ago

On 7/16/20 10:50 AM, Cornelia Huck wrote:
> Fix the type name in the mdevctl example.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>

Yup, that is backwards.

Reviewed-by: Eric Farman <farman@linux.ibm.com>

> ---
> 
> I always seem to get this one wrong, and mdevctl does not complain until
> it wants to start the device...
> 
> ---
>  docs/system/s390x/vfio-ccw.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/s390x/vfio-ccw.rst b/docs/system/s390x/vfio-ccw.rst
> index 8f65442c0f56..41e0bad5b489 100644
> --- a/docs/system/s390x/vfio-ccw.rst
> +++ b/docs/system/s390x/vfio-ccw.rst
> @@ -29,7 +29,7 @@ automatically, use
>  
>     [root@host ~]# driverctl -b css set-override 0.0.0313 vfio_ccw
>     [root@host ~]# mdevctl define -u 7e270a25-e163-4922-af60-757fc8ed48c6 \
> -                  -p 0.0.0313 -t vfio-ccw_io -a
> +                  -p 0.0.0313 -t vfio_ccw-io -a
>  
>  If using ``mdevctl`` is not possible or wanted, follow the manual procedure
>  below.
> 

Re: [PATCH] docs/s390x: fix vfio-ccw type
Posted by Cornelia Huck 3 years, 9 months ago
On Thu, 16 Jul 2020 16:50:31 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> Fix the type name in the mdevctl example.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> 
> I always seem to get this one wrong, and mdevctl does not complain until
> it wants to start the device...
> 
> ---
>  docs/system/s390x/vfio-ccw.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/s390x/vfio-ccw.rst b/docs/system/s390x/vfio-ccw.rst
> index 8f65442c0f56..41e0bad5b489 100644
> --- a/docs/system/s390x/vfio-ccw.rst
> +++ b/docs/system/s390x/vfio-ccw.rst
> @@ -29,7 +29,7 @@ automatically, use
>  
>     [root@host ~]# driverctl -b css set-override 0.0.0313 vfio_ccw
>     [root@host ~]# mdevctl define -u 7e270a25-e163-4922-af60-757fc8ed48c6 \
> -                  -p 0.0.0313 -t vfio-ccw_io -a
> +                  -p 0.0.0313 -t vfio_ccw-io -a
>  
>  If using ``mdevctl`` is not possible or wanted, follow the manual procedure
>  below.

Queued to s390-fixes.